Skip to content

Commit

Permalink
MacViews: Do not set delegating layer background color
Browse files Browse the repository at this point in the history
Setting the background color on delegated layers can cause artifacts
(only non-tiled areas get the background color). This also appears
not to have been necessary.

Bug: 845968, 840173
Change-Id: If8eca7d3eb793952a9a606a2d27683b02d2c4b3f
Reviewed-on: https://chromium-review.googlesource.com/1071117
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561390}
  • Loading branch information
ccameron-chromium authored and Commit Bot committed May 24, 2018
1 parent 4df0ff8 commit 1cdbef8
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,6 @@ void OnCompositingShuttingDown(ui::Compositor* compositor) override {}

void BrowserCompositorMac::SetBackgroundColor(SkColor background_color) {
background_color_ = background_color;
root_layer_->SetColor(background_color_);
if (recyclable_compositor_)
recyclable_compositor_->compositor()->SetBackgroundColor(background_color_);
}
Expand Down
2 changes: 0 additions & 2 deletions content/browser/renderer_host/render_widget_host_view_mac.mm
Original file line number Diff line number Diff line change
Expand Up @@ -204,8 +204,6 @@ new BrowserCompositorMac(this, this, host()->is_hidden(),
}

void RenderWidgetHostViewMac::SetParentUiLayer(ui::Layer* parent_ui_layer) {
// TODO(ccameron): This path appears to be buggy.
return;
if (parent_ui_layer)
display_only_using_parent_ui_layer_ = true;
if (browser_compositor_)
Expand Down

0 comments on commit 1cdbef8

Please sign in to comment.