Skip to content

Commit

Permalink
Replace forward declarations with includes in TaskRunner APIs.
Browse files Browse the repository at this point in the history
This CL:
- Adds #include "base/location.h" in base/task_runner.h
- Adds #include "base/single_thread_task_runner.h"
      in base/threading/thread_task_runner_handle.h
- Adds #include "base/sequenced_task_runner.h"
      in base/threading/sequenced_task_runner_handle.h

This will be followed by a mass removal of includes that
are no longer necessary.

BUG=618793

Review-Url: https://codereview.chromium.org/2053503004
Cr-Commit-Position: refs/heads/master@{#399044}
  • Loading branch information
fdoray authored and Commit bot committed Jun 9, 2016
1 parent d450584 commit 1d08c58
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 10 deletions.
5 changes: 1 addition & 4 deletions base/task_runner.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,10 @@

#include "base/base_export.h"
#include "base/callback_forward.h"
#include "base/location.h"
#include "base/memory/ref_counted.h"
#include "base/time/time.h"

namespace tracked_objects {
class Location;
} // namespace tracked_objects

namespace base {

struct TaskRunnerTraits;
Expand Down
1 change: 0 additions & 1 deletion base/threading/sequenced_task_runner_handle.cc
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

#include "base/lazy_instance.h"
#include "base/logging.h"
#include "base/sequenced_task_runner.h"
#include "base/threading/sequenced_worker_pool.h"
#include "base/threading/thread_local.h"
#include "base/threading/thread_task_runner_handle.h"
Expand Down
3 changes: 1 addition & 2 deletions base/threading/sequenced_task_runner_handle.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,10 @@
#include "base/compiler_specific.h"
#include "base/macros.h"
#include "base/memory/ref_counted.h"
#include "base/sequenced_task_runner.h"

namespace base {

class SequencedTaskRunner;

class BASE_EXPORT SequencedTaskRunnerHandle {
public:
// Returns a SequencedTaskRunner which guarantees that posted tasks will only
Expand Down
1 change: 0 additions & 1 deletion base/threading/thread_task_runner_handle.cc
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

#include "base/lazy_instance.h"
#include "base/logging.h"
#include "base/single_thread_task_runner.h"
#include "base/threading/sequenced_task_runner_handle.h"
#include "base/threading/thread_local.h"

Expand Down
3 changes: 1 addition & 2 deletions base/threading/thread_task_runner_handle.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,10 @@
#include "base/base_export.h"
#include "base/macros.h"
#include "base/memory/ref_counted.h"
#include "base/single_thread_task_runner.h"

namespace base {

class SingleThreadTaskRunner;

// ThreadTaskRunnerHandle stores a reference to a thread's TaskRunner
// in thread-local storage. Callers can then retrieve the TaskRunner
// for the current thread by calling ThreadTaskRunnerHandle::Get().
Expand Down

0 comments on commit 1d08c58

Please sign in to comment.