forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Reland "Replace GPU Compositing feature with GL"
This reverts commit baefa2e. Reason for revert: Fixed the failing tests. In my refactor I removed a check to gpu_feature_info_.IsInitialized(), which would cause an issue during fallback if the gpu info was not ready yet. Original change's description: > Revert "Replace GPU Compositing feature with GL" > > This reverts commit 8834f5a. > > Reason for revert: Likely culprit for consistent failure on Linux FYI Debug (NVIDIA): both GpuProcess_swiftshader_for_webgl and GpuProcess_feature_status_under_swiftshader fail DCHECK(gpu_feature_info_.IsInitialized()) > > Original change's description: > > Replace GPU Compositing feature with GL > > > > GPU compositing is never specifically blacklisted in > > software_rendering_list.json, only when all are disabled, so remove it, > > and add GPU_FEATURE_TYPE_GL. Use this as a proxy for GPU compositing for > > now. This will need to be fixed to support the case where GL is > > blacklisted, but Vulkan is still enabled. > > > > Bug: 1005383 > > Change-Id: I0330021cfa59c6c4cf2719785f7931e53ec50f80 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917753 > > Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> > > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > > Reviewed-by: kylechar <kylechar@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#719399} > > TBR=zmo@chromium.org,kylechar@chromium.org,sgilhuly@chromium.org > > Change-Id: I65f801a3d790f864367101cbaabc7991308ffe03 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1005383 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940172 > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Corentin Wallez <cwallez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#719608} Change-Id: I0247a230dc074a7425bcd2cbfd25d1fb41322db1 Bug: 1005383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940884 Reviewed-by: kylechar <kylechar@chromium.org> Reviewed-by: Sean Gilhuly <sgilhuly@chromium.org> Reviewed-by: Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Auto-Submit: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#720039}
- Loading branch information
Sean Gilhuly
authored and
Commit Bot
committed
Nov 28, 2019
1 parent
6f71775
commit 1e54ddb
Showing
14 changed files
with
55 additions
and
53 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1587,6 +1587,7 @@ | |
"features": [ | ||
"all", | ||
{"exceptions": [ | ||
"accelerated_gl", | ||
"accelerated_webgl" | ||
]} | ||
] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters