Skip to content

Commit

Permalink
Updated the .gn check_targets list to include all* of third_party/*
Browse files Browse the repository at this point in the history 
gn check by default only works on those targets that are listed in
check_targets, and since we can't whitelist all of //third_party,
every sub-folder has to be individually listed. Some were listed
before but this adds another two hundred.

5-10% of the folders are still excluded because they have one or
more internal check problems. Specifically third_party/blink is
not included yet. Working on it.

Bug: 898837
Change-Id: Ia2a2cc14c00ecfdb956eb553664efe46356dedc3
Reviewed-on: https://chromium-review.googlesource.com/c/1299086
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#603156}
  • Loading branch information
@bratell-at-opera
bratell-at-opera authored and Commit Bot committed Oct 26, 2018
1 parent 64339f1 commit 1e733a0
Showing 1 changed file with 280 additions and 4 deletions.
284 changes: 280 additions & 4 deletions .gn
View file
Original file line number Diff line number Diff line change
Expand Up @@ -314,20 +314,296 @@ check_targets = [
"//testing/*",

#"//third_party/*", # May not ever want this.
"//third_party/Python-Markdown/*",

# "//third_party/SPIRV-Tools/*", # 30ish errors
"//third_party/WebKit/*",

# "//third_party/abseil-cpp/*", # 4 errors
"//third_party/accessibility-audit/*",
"//third_party/accessibility_test_framework/*",
"//third_party/adobe/*",
"//third_party/afl/*",
"//third_party/analytics/*",
"//third_party/android_build_tools/*",
"//third_party/android_data_chart/*",
"//third_party/android_deps/*",
"//third_party/android_media/*",
"//third_party/android_ndk/*",
"//third_party/android_opengl/*",
"//third_party/android_platform/*",
"//third_party/android_protobuf/*",
"//third_party/android_sdk/*",
"//third_party/android_support_test_runner/*",
"//third_party/android_swipe_refresh/*",
"//third_party/android_system_sdk/*",
"//third_party/android_testrunner/*",
"//third_party/android_tools/*",

# "//third_party/angle/*", # 30ish errors
"//third_party/apache-portable-runtime/*",
"//third_party/apache_velocity/*",
"//third_party/apache-win32/*",
"//third_party/apk-patch-size-estimator/*",
"//third_party/apple_apsl/*",
"//third_party/appurify-python/*",
"//third_party/arcore-android-sdk/*",
"//third_party/ashmem/*",
"//third_party/auto/*",
"//third_party/axe-core/*",
"//third_party/bazel/*",
"//third_party/bidichecker/*",
"//third_party/binutils/*",
"//third_party/blanketjs/*",

# "//third_party/blink/*", # Errors: https://crbug.com/800764
#"//third_party/breakpad/*", # Small errors.
"//third_party/boringssl/*",
"//third_party/bouncycastle/*",
"//third_party/brotli/*",
"//third_party/bspatch/*",
"//third_party/byte_buddy/*",

# "//third_party/cacheinvalidation/*", # 2 errors
"//third_party/catapult/*",
"//third_party/cct_dynamic_module/*",

# "//third_party/ced/*", # 6 errors
"//third_party/chaijs/*",
"//third_party/checkstyle/*",
"//third_party/chromevox/*",
"//third_party/chromite/*",
"//third_party/cld_2/*",
"//third_party/cld_3/*",
"//third_party/closure_compiler/*",
"//third_party/colorama/*",

# "//third_party/crashpad/*", 20ish errors
# "//third_party/crc32c/*", 10ish errors
"//third_party/cros_system_api/*",
"//third_party/custom_tabs_client/*",
"//third_party/cython/*",
"//third_party/d3/*",
"//third_party/dawn/*",
"//third_party/decklink/*",
"//third_party/depot_tools/*",
"//third_party/deqp/*",
"//third_party/devscripts/*",
"//third_party/devtools-node-modules/*",
"//third_party/dom_distiller_js/*",
"//third_party/elfutils/*",
"//third_party/errorprone/*",
"//third_party/espresso/*",
"//third_party/eu-strip/*",
"//third_party/expat/*",
"//third_party/eyesfree/*",
"//third_party/feed/*",

# "//third_party/ffmpeg/*", # android_cronet only https://crbug.com/898793
"//third_party/fips181/*",
"//third_party/flac/*",

# "//third_party/flatbuffers/*", # 1 error
"//third_party/flot/*",
"//third_party/fontconfig/*",
"//third_party/freetype/*",
"//third_party/freetype2/*",
"//third_party/freetype-android/*",
"//third_party/fuchsia-sdk/*",
"//third_party/gestures/*",
"//third_party/gif_player/*",
"//third_party/glfw/*",
"//third_party/glslang/*",
"//third_party/glslang-angle/*",
"//third_party/google_appengine_cloudstorage/*",
"//third_party/google_input_tools/*",
"//third_party/googletest/*",
"//third_party/google_toolbox_for_mac/*",
"//third_party/google-truth/*",
"//third_party/gradle_wrapper/*",
"//third_party/gson/*",
"//third_party/guava/*",
"//third_party/gvr-android-keyboard/*",
"//third_party/gvr-android-sdk/*",
"//third_party/hamcrest/*",
"//third_party/harfbuzz-ng/*",
"//third_party/hunspell/*",
"//third_party/hunspell/*",
"//third_party/hunspell_dictionaries/*",
"//third_party/iaccessible2/*",
"//third_party/iccjpeg/*",

# "//third_party/icu/*", # Many errors
"//third_party/icu4j/*",
"//third_party/ijar/*",
"//third_party/ink/*",
"//third_party/inspector_protocol/*",
"//third_party/instrumented_libraries/*",
"//third_party/intellij/*",
"//third_party/isimpledom/*",
"//third_party/javax_inject/*",
"//third_party/jinja2/*",
"//third_party/jmake/*",
"//third_party/jsoncpp/*",
"//third_party/jsr-305/*",
"//third_party/jstemplate/*",
"//third_party/junit/*",
"//third_party/khronos/*",
"//third_party/lcov/*",
"//third_party/leakcanary/*",
"//third_party/leveldatabase/*",

#"//third_party/libaddressinput/*", # Small errors.
"//third_party/libFuzzer/*",
"//third_party/libXNVCtrl/*",

# "//third_party/libaddressinput/*", # Small errors.
# "//third_party/libaom/*", # Many errors
"//third_party/libc++/*",
"//third_party/libc++abi/*",
"//third_party/libcxx-pretty-printers/*",
"//third_party/libdrm/*",
"//third_party/libevdev/*",
"//third_party/libexif/*",
"//third_party/libjingle/*",

# "//third_party/libjingle_xmpp/*", # 30ish errors
"//third_party/libjpeg/*",

# "//third_party/libjpeg_turbo/*", # 3 errors
# "//third_party/liblouis/*", # Small errors
"//third_party/libovr/*",
"//third_party/libphonenumber/*",
"//third_party/libpng/*",
"//third_party/libprotobuf-mutator/*",
"//third_party/libsecret/*",
"//third_party/libsrtp/*",

# "//third_party/libsync/*", # Small error
"//third_party/libudev/*",
"//third_party/libusb/*",

# "//third_party/libvpx/*", # Many errors
"//third_party/libvpx_new/*",
"//third_party/libwebm/*",

#"//third_party/libwebp/*", # Errors: https://crbug.com/800762
"//third_party/libxml/*",

# "//third_party/libxslt/*", # Small error
"//third_party/libyuv/*",
"//third_party/llvm/*",
"//third_party/llvm-bootstrap/*",
"//third_party/llvm-bootstrap-install/*",
"//third_party/llvm-build-tools/*",
"//third_party/logilab/*",
"//third_party/lss/*",
"//third_party/lzma_sdk/*",
"//third_party/mach_override/*",
"//third_party/markdown/*",
"//third_party/markupsafe/*",
"//third_party/material_design_icons/*",
"//third_party/mesa/*",
"//third_party/mesa_headers/*",
"//third_party/metrics_proto/*",
"//third_party/minigbm/*",
"//third_party/mocha/*",
"//third_party/mockito/*",
"//third_party/modp_b64/*",
"//third_party/motemplate/*",
"//third_party/mozilla/*",
"//third_party/mtpd/*",
"//third_party/netty4/*",
"//third_party/netty-tcnative/*",
"//third_party/node/*",
"//third_party/nvml/*",
"//third_party/objenesis/*",
"//third_party/ocmock/*",

# "//third_party/openh264/*", # 1 error WelsCircleQueue.h
# "//third_party/openmax_dl/*", # 1 error
"//third_party/openvr/*",
"//third_party/opus/*",
"//third_party/ots/*",
"//third_party/ow2_asm/*",

# "//third_party/pdfium/*", # 3 errors
# "//third_party/perfetto/*", # Simple fix: https://crbug.com/898779
"//third_party/pexpect/*",
"//third_party/ply/*",
"//third_party/polymer/*",
"//third_party/proguard/*",
"//third_party/protobuf/*",
"//third_party/pycoverage/*",
"//third_party/pyelftools/*",
"//third_party/pyftpdlib/*",
"//third_party/pyjson5/*",
"//third_party/pylint/*",
"//third_party/pymock/*",
"//third_party/pystache/*",
"//third_party/py_trace_event/*",
"//third_party/pywebsocket/*",
"//third_party/qcms/*",
"//third_party/quic_trace/*",
"//third_party/qunit/*",
"//third_party/r8/*",
"//third_party/re2/*",
"//third_party/requests/*",
"//third_party/retrolambda/*",
"//third_party/rnnoise/*",
"//third_party/robolectric/*",
"//third_party/safe_browsing/*",
"//third_party/scan-build/*",

# "//third_party/sfntly/*", # 20ish errors
"//third_party/shaderc/*",
"//third_party/simplejson/*",
"//third_party/sinonjs/*",
"//third_party/skia/*",
"//third_party/smhasher/*",
"//third_party/snappy/*",

#"//third_party/WebKit/*", # Errors: https://crbug.com/800764
"//third_party/speech-dispatcher/*",
"//third_party/spirv-cross/*",
"//third_party/spirv-headers/*",
"//third_party/spirv-tools-angle/*",
"//third_party/sqlite/*",
"//third_party/sqlite4java/*",
"//third_party/stp/*",
"//third_party/sudden_motion_sensor/*",

# "//third_party/swiftshader/*", # 1 error
"//third_party/swig/*",
"//third_party/tcmalloc/*",
"//third_party/test_fonts/*",
"//third_party/tlslite/*",
"//third_party/ub-uiautomator/*",
"//third_party/unrar/*",
"//third_party/usb_ids/*",
"//third_party/usrsctp/*",
"//third_party/v4l-utils/*",
"//third_party/valgrind/*",
"//third_party/visualmetrics/*",
"//third_party/vulkan/*",
"//third_party/vulkan-validation-layers/*",

# "//third_party/wayland/*", # Small errors
"//third_party/wayland-protocols/*",
"//third_party/wds/*",
"//third_party/web-animations-js/*",
"//third_party/webdriver/*",
"//third_party/webgl/*",
"//third_party/webpagereplay/*",
"//third_party/webrtc/*",
"//third_party/webrtc_overrides/*",
"//third_party/widevine/*",
"//third_party/win_build_output/*",
"//third_party/woff2/*",
"//third_party/wtl/*",
"//third_party/xdg-utils/*",
"//third_party/xstream/*",
"//third_party/xstream/*",
"//third_party/yara/*",
"//third_party/yasm/*",

# "//third_party/zlib/*", # 15ish errors
"//third_party/webrtc/*",
"//third_party/webrtc_overrides/*",
"//tools/*",
Expand Down

0 comments on commit 1e733a0

Please sign in to comment.