Skip to content

Commit

Permalink
Removed file_path_watcher_mac.cc, which isn't used anymore.
Browse files Browse the repository at this point in the history
Review URL: https://chromiumcodereview.appspot.com/10500012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140272 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
joaodasilva@chromium.org committed Jun 4, 2012
1 parent 9906598 commit 20f0609
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 504 deletions.
2 changes: 1 addition & 1 deletion base/files/file_path_watcher.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ namespace files {
// than on Windows or Linux. FilePathWatcher on Linux and Windows will detect
// modifications to files in a watched directory. FilePathWatcher on Mac will
// detect the creation and deletion of files in a watched directory, but will
// not detect modifications to those files. See file_path_watcher_mac.cc for
// not detect modifications to those files. See file_path_watcher_kqueue.cc for
// details.
class BASE_EXPORT FilePathWatcher {
public:
Expand Down
14 changes: 7 additions & 7 deletions base/files/file_path_watcher_kqueue.cc
Original file line number Diff line number Diff line change
Expand Up @@ -205,15 +205,15 @@ void FilePathWatcherImpl::CloseFileDescriptor(int *fd) {
}

if (HANDLE_EINTR(close(*fd)) != 0) {
PLOG(ERROR) << "close";
DPLOG(ERROR) << "close";
}
*fd = -1;
}

bool FilePathWatcherImpl::AreKeventValuesValid(struct kevent* kevents,
int count) {
if (count < 0) {
PLOG(ERROR) << "kevent";
DPLOG(ERROR) << "kevent";
return false;
}
bool valid = true;
Expand All @@ -237,7 +237,7 @@ bool FilePathWatcherImpl::AreKeventValuesValid(struct kevent* kevents,
path_name = base::StringPrintf(
"fd %d", *reinterpret_cast<int*>(&kevents[i].ident));
}
LOG(ERROR) << "Error: " << kevents[i].data << " for " << path_name;
DLOG(ERROR) << "Error: " << kevents[i].data << " for " << path_name;
valid = false;
}
}
Expand Down Expand Up @@ -348,8 +348,8 @@ bool FilePathWatcherImpl::UpdateWatches(bool* target_file_affected) {

void FilePathWatcherImpl::OnFileCanReadWithoutBlocking(int fd) {
DCHECK(MessageLoopForIO::current());
CHECK_EQ(fd, kqueue_);
CHECK(events_.size());
DCHECK_EQ(fd, kqueue_);
DCHECK(events_.size());

// Request the file system update notifications that have occurred and return
// them in |updates|. |count| will contain the number of updates that have
Expand Down Expand Up @@ -442,12 +442,12 @@ bool FilePathWatcherImpl::Watch(const FilePath& path,

kqueue_ = kqueue();
if (kqueue_ == -1) {
PLOG(ERROR) << "kqueue";
DPLOG(ERROR) << "kqueue";
return false;
}

int last_entry = EventsForPath(target_, &events_);
CHECK_NE(last_entry, 0);
DCHECK_NE(last_entry, 0);

EventVector responses(last_entry);

Expand Down
Loading

0 comments on commit 20f0609

Please sign in to comment.