Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Reland "[webauthn] Port fingerprint enrollment assets to lottie"
This is a reland of 98450e6 The original change uncovered a bug by changing the timing of requests. If <cr-lottie> was detached while the animation request was in-flight, the worker would be terminated but the onreadystatus change callback would still fire and try to send a message to the terminated worker. Fix this by aborting the request when detaching. The reland also fixes a similar racy issue when changing the animation URL. If the URL changes before the first one had a chance to load, then whichever request comes last would be the one shown. This fixes that issue by cancelling the first request before starting the new one. Added tests for both issues. Bug: 1104105 Original change's description: > [webauthn] Port fingerprint enrollment assets to lottie > > Replace the fingerprint enrollment APNGs on the webauthn fingerprint > enrollment page by lottie versions. This shaves ~200kb and adds a > transparent background to the fingerprint animation that partially fixes > issue 1041877. > > Also, add "hidden" and "singleLoop" attributes to lottie to match the > APNG img tag behaviour; and update the wrapper to allow dynamically > loading another animation into the same element. > > Finally, this updates the settings UI worker CSP to allow the lottie > worker. > > Fixed: 1082312 > Change-Id: I0c92663ec6e1bfd76c03f995b6e96d210f26173f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116557 > Commit-Queue: Nina Satragno <nsatragno@chromium.org> > Reviewed-by: Malay Keshav <malaykeshav@chromium.org> > Reviewed-by: dpapad <dpapad@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#786933} Change-Id: I6686e11295d7c0154659ae5c97cdf1cb773344f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290847 Reviewed-by: dpapad <dpapad@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#788790}
- Loading branch information