Skip to content

Commit

Permalink
[Language] Default Translate Ranker Model
Browse files Browse the repository at this point in the history
1/ Add new Ranker config to field trial testing
2/ Set the default model to be consistent with the 99% Finch group

Bug: 852921
Change-Id: I04497f6a80d810a506e40b7ff9e4d1500ffc191c
Reviewed-on: https://chromium-review.googlesource.com/1179814
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Reviewed-by: Michael Martis <martis@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584791}
  • Loading branch information
Anthony Vallee-Dubois authored and Commit Bot committed Aug 21, 2018
1 parent a632a41 commit 22981ad
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 3 deletions.
2 changes: 1 addition & 1 deletion components/translate/core/browser/translate_ranker_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ const char kDefaultTranslateRankerModelURL[] =
#elif defined(USE_AURA)
const char kDefaultTranslateRankerModelURL[] =
"https://www.gstatic.com/chrome/intelligence/assist/ranker/models/"
"translate/translate_ranker_20180123.model";
"translate/2017/03/translate_ranker_model_20170329.pb.bin";
#else
const char kDefaultTranslateRankerModelURL[] =
"https://www.gstatic.com/chrome/intelligence/assist/ranker/models/"
Expand Down
21 changes: 19 additions & 2 deletions testing/variations/fieldtrial_testing_config.json
Original file line number Diff line number Diff line change
Expand Up @@ -4273,11 +4273,28 @@
{
"platforms": [
"chromeos",
"ios",
"linux",
"mac",
"windows"
],
"experiments": [
{
"name": "launch_20180628_model_20170329_with_blacklist_override_default",
"params": {
"translate-ranker-model-url": "https://www.gstatic.com/chrome/intelligence/assist/ranker/models/translate/2017/03/translate_ranker_model_20170329.pb.bin"
},
"enable_features": [
"TranslateRankerAutoBlacklistOverride",
"TranslateRankerEnforcement",
"TranslateRankerQuery"
]
}
]
},
{
"platforms": [
"ios",
"mac"
],
"experiments": [
{
"name": "20180123_launch",
Expand Down

0 comments on commit 22981ad

Please sign in to comment.