Skip to content

Commit

Permalink
media: Rename |enable_*_demuxing| to |enable_platform_*|
Browse files Browse the repository at this point in the history
This is a followup of crrev.com/c/1816800.

Currently these flags control not only the demuxing, but the platform
support in some cases. Rename the flags so they become generic flags
controlling platform codec support.

Updated:
- enable_ac3_eac3_audio_demuxing
- enable_mpeg_h_audio_demuxing
- enable_dolby_vision_demuxing

Also updates the corresponding buildflags.

Test: No functionality change.
Change-Id: I0c8e504bf922232d3eadef1803bd34a598c87179
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817025
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699001}
  • Loading branch information
xhwang-chromium authored and Commit Bot committed Sep 23, 2019
1 parent aa72098 commit 23236dc
Show file tree
Hide file tree
Showing 18 changed files with 77 additions and 77 deletions.
12 changes: 6 additions & 6 deletions chromecast/renderer/media/key_systems_cast.cc
Original file line number Diff line number Diff line change
Expand Up @@ -127,20 +127,20 @@ SupportedCodecs GetCastEmeSupportedCodecs() {
codecs |= ::media::EME_CODEC_HEVC;
#endif // BUILDFLAG(ENABLE_PLATFORM_HEVC)

#if BUILDFLAG(ENABLE_DOLBY_VISION_DEMUXING)
#if BUILDFLAG(ENABLE_PLATFORM_DOLBY_VISION)
codecs |= ::media::EME_CODEC_DOLBY_VISION_AVC;
#if BUILDFLAG(ENABLE_PLATFORM_HEVC)
codecs |= ::media::EME_CODEC_DOLBY_VISION_HEVC;
#endif // BUILDFLAG(ENABLE_PLATFORM_HEVC)
#endif // BUILDFLAG(ENABLE_DOLBY_VISION_DEMUXING)
#endif // BUILDFLAG(ENABLE_PLATFORM_DOLBY_VISION)

#if BUILDFLAG(ENABLE_AC3_EAC3_AUDIO_DEMUXING)
#if BUILDFLAG(ENABLE_PLATFORM_AC3_EAC3_AUDIO)
codecs |= ::media::EME_CODEC_AC3 | ::media::EME_CODEC_EAC3;
#endif // BUILDFLAG(ENABLE_AC3_EAC3_AUDIO_DEMUXING)
#endif // BUILDFLAG(ENABLE_PLATFORM_AC3_EAC3_AUDIO)

#if BUILDFLAG(ENABLE_MPEG_H_AUDIO_DEMUXING)
#if BUILDFLAG(ENABLE_PLATFORM_MPEG_H_AUDIO)
codecs |= ::media::EME_CODEC_MPEG_H_AUDIO;
#endif // BUILDFLAG(ENABLE_MPEG_H_AUDIO_DEMUXING)
#endif // BUILDFLAG(ENABLE_PLATFORM_MPEG_H_AUDIO)

return codecs;
}
Expand Down
4 changes: 2 additions & 2 deletions components/cdm/browser/cdm_message_filter_android.cc
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ const CodecInfo<media::VideoCodec> kMP4VideoCodecsToQuery[] = {
#if BUILDFLAG(ENABLE_PLATFORM_HEVC)
{media::EME_CODEC_HEVC, media::kCodecHEVC},
#endif
#if BUILDFLAG(ENABLE_DOLBY_VISION_DEMUXING)
#if BUILDFLAG(ENABLE_PLATFORM_DOLBY_VISION)
{media::EME_CODEC_DOLBY_VISION_AVC, media::kCodecDolbyVision},
#if BUILDFLAG(ENABLE_PLATFORM_HEVC)
{media::EME_CODEC_DOLBY_VISION_HEVC, media::kCodecDolbyVision},
Expand All @@ -68,7 +68,7 @@ const CodecInfo<media::AudioCodec> kWebMAudioCodecsToQuery[] = {
const CodecInfo<media::AudioCodec> kMP4AudioCodecsToQuery[] = {
#if BUILDFLAG(USE_PROPRIETARY_CODECS)
{media::EME_CODEC_AAC, media::kCodecAAC},
#if BUILDFLAG(ENABLE_AC3_EAC3_AUDIO_DEMUXING)
#if BUILDFLAG(ENABLE_PLATFORM_AC3_EAC3_AUDIO)
{media::EME_CODEC_AC3, media::kCodecAC3},
{media::EME_CODEC_EAC3, media::kCodecEAC3},
#endif
Expand Down
6 changes: 3 additions & 3 deletions media/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@ buildflag_header("media_buildflags") {
flags = [
"ALTERNATE_CDM_STORAGE_ID_KEY=\"$alternate_cdm_storage_id_key\"",
"CDM_PLATFORM_SPECIFIC_PATH=\"$cdm_platform_specific_path\"",
"ENABLE_AC3_EAC3_AUDIO_DEMUXING=$enable_ac3_eac3_audio_demuxing",
"ENABLE_PLATFORM_AC3_EAC3_AUDIO=$enable_platform_ac3_eac3_audio",
"ENABLE_CBCS_ENCRYPTION_SCHEME=$enable_cbcs_encryption_scheme",
"ENABLE_CDM_HOST_VERIFICATION=$enable_cdm_host_verification",
"ENABLE_CDM_STORAGE_ID=$enable_cdm_storage_id",
"ENABLE_DAV1D_DECODER=$enable_dav1d_decoder",
"ENABLE_AV1_DECODER=$enable_av1_decoder",
"ENABLE_DOLBY_VISION_DEMUXING=$enable_dolby_vision_demuxing",
"ENABLE_PLATFORM_DOLBY_VISION=$enable_platform_dolby_vision",
"ENABLE_FFMPEG=$media_use_ffmpeg",
"ENABLE_FFMPEG_VIDEO_DECODERS=$enable_ffmpeg_video_decoders",
"ENABLE_PLATFORM_HEVC=$enable_platform_hevc",
Expand All @@ -36,7 +36,7 @@ buildflag_header("media_buildflags") {
"ENABLE_LOGGING_OVERRIDE=$enable_logging_override",
"ENABLE_MEDIA_REMOTING=$enable_media_remoting",
"ENABLE_MEDIA_REMOTING_RPC=$enable_media_remoting_rpc",
"ENABLE_MPEG_H_AUDIO_DEMUXING=$enable_mpeg_h_audio_demuxing",
"ENABLE_PLATFORM_MPEG_H_AUDIO=$enable_platform_mpeg_h_audio",
"ENABLE_MSE_MPEG2TS_STREAM_PARSER=$enable_mse_mpeg2ts_stream_parser",
"USE_PROPRIETARY_CODECS=$proprietary_codecs",
]
Expand Down
12 changes: 6 additions & 6 deletions media/base/eme_constants.h
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,12 @@ constexpr SupportedCodecs GetMp4AudioCodecs() {
SupportedCodecs codecs = EME_CODEC_FLAC;
#if BUILDFLAG(USE_PROPRIETARY_CODECS)
codecs |= EME_CODEC_AAC;
#if BUILDFLAG(ENABLE_AC3_EAC3_AUDIO_DEMUXING)
#if BUILDFLAG(ENABLE_PLATFORM_AC3_EAC3_AUDIO)
codecs |= EME_CODEC_AC3 | EME_CODEC_EAC3;
#endif // BUILDFLAG(ENABLE_AC3_EAC3_AUDIO_DEMUXING)
#if BUILDFLAG(ENABLE_MPEG_H_AUDIO_DEMUXING)
#endif // BUILDFLAG(ENABLE_PLATFORM_AC3_EAC3_AUDIO)
#if BUILDFLAG(ENABLE_PLATFORM_MPEG_H_AUDIO)
codecs |= EME_CODEC_MPEG_H_AUDIO;
#endif // BUILDFLAG(ENABLE_MPEG_H_AUDIO_DEMUXING)
#endif // BUILDFLAG(ENABLE_PLATFORM_MPEG_H_AUDIO)
#endif // BUILDFLAG(USE_PROPRIETARY_CODECS)
return codecs;
}
Expand All @@ -72,12 +72,12 @@ constexpr SupportedCodecs GetMp4VideoCodecs() {
#if BUILDFLAG(ENABLE_PLATFORM_HEVC)
codecs |= EME_CODEC_HEVC;
#endif // BUILDFLAG(ENABLE_PLATFORM_HEVC)
#if BUILDFLAG(ENABLE_DOLBY_VISION_DEMUXING)
#if BUILDFLAG(ENABLE_PLATFORM_DOLBY_VISION)
codecs |= EME_CODEC_DOLBY_VISION_AVC;
#if BUILDFLAG(ENABLE_PLATFORM_HEVC)
codecs |= EME_CODEC_DOLBY_VISION_HEVC;
#endif // BUILDFLAG(ENABLE_PLATFORM_HEVC)
#endif // BUILDFLAG(ENABLE_DOLBY_VISION_DEMUXING)
#endif // BUILDFLAG(ENABLE_PLATFORM_DOLBY_VISION)
#endif // BUILDFLAG(USE_PROPRIETARY_CODECS)
return codecs;
}
Expand Down
18 changes: 9 additions & 9 deletions media/base/mime_util_internal.cc
Original file line number Diff line number Diff line change
Expand Up @@ -320,23 +320,23 @@ void MimeUtil::AddSupportedMediaFormats() {
CodecSet avc_and_aac(aac);
avc_and_aac.emplace(H264);

#if BUILDFLAG(ENABLE_AC3_EAC3_AUDIO_DEMUXING)
#if BUILDFLAG(ENABLE_PLATFORM_AC3_EAC3_AUDIO)
mp4_audio_codecs.emplace(AC3);
mp4_audio_codecs.emplace(EAC3);
#endif // BUILDFLAG(ENABLE_AC3_EAC3_AUDIO_DEMUXING)
#endif // BUILDFLAG(ENABLE_PLATFORM_AC3_EAC3_AUDIO)

#if BUILDFLAG(ENABLE_MPEG_H_AUDIO_DEMUXING)
#if BUILDFLAG(ENABLE_PLATFORM_MPEG_H_AUDIO)
mp4_audio_codecs.emplace(MPEG_H_AUDIO);
#endif // BUILDFLAG(ENABLE_MPEG_H_AUDIO_DEMUXING)
#endif // BUILDFLAG(ENABLE_PLATFORM_MPEG_H_AUDIO)

mp4_video_codecs.emplace(H264);
#if BUILDFLAG(ENABLE_PLATFORM_HEVC)
mp4_video_codecs.emplace(HEVC);
#endif // BUILDFLAG(ENABLE_PLATFORM_HEVC)

#if BUILDFLAG(ENABLE_DOLBY_VISION_DEMUXING)
#if BUILDFLAG(ENABLE_PLATFORM_DOLBY_VISION)
mp4_video_codecs.emplace(DOLBY_VISION);
#endif // BUILDFLAG(ENABLE_DOLBY_VISION_DEMUXING)
#endif // BUILDFLAG(ENABLE_PLATFORM_DOLBY_VISION)
#endif // BUILDFLAG(USE_PROPRIETARY_CODECS)
#if BUILDFLAG(ENABLE_AV1_DECODER)
mp4_video_codecs.emplace(AV1);
Expand Down Expand Up @@ -661,7 +661,7 @@ bool MimeUtil::IsCodecSupportedOnAndroid(

case AC3:
case EAC3:
#if BUILDFLAG(ENABLE_AC3_EAC3_AUDIO_DEMUXING)
#if BUILDFLAG(ENABLE_PLATFORM_AC3_EAC3_AUDIO)
return true;
#else
return false;
Expand Down Expand Up @@ -831,14 +831,14 @@ bool MimeUtil::ParseCodecHelper(const std::string& mime_type_lower_case,
}
#endif

#if BUILDFLAG(ENABLE_DOLBY_VISION_DEMUXING)
#if BUILDFLAG(ENABLE_PLATFORM_DOLBY_VISION)
if (ParseDolbyVisionCodecId(codec_id, out_profile, out_level)) {
out_result->codec = MimeUtil::DOLBY_VISION;
return true;
}
#endif

#if BUILDFLAG(ENABLE_MPEG_H_AUDIO_DEMUXING)
#if BUILDFLAG(ENABLE_PLATFORM_MPEG_H_AUDIO)
if (base::StartsWith(codec_id, "mhm1.", base::CompareCase::SENSITIVE) ||
base::StartsWith(codec_id, "mha1.", base::CompareCase::SENSITIVE)) {
out_result->codec = MimeUtil::MPEG_H_AUDIO;
Expand Down
2 changes: 1 addition & 1 deletion media/base/mime_util_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ static bool HasDolbyVisionSupport() {
}

static bool HasEac3Support() {
#if BUILDFLAG(ENABLE_AC3_EAC3_AUDIO_DEMUXING)
#if BUILDFLAG(ENABLE_PLATFORM_AC3_EAC3_AUDIO)
return true;
#else
return false;
Expand Down
4 changes: 2 additions & 2 deletions media/base/video_codecs.cc
Original file line number Diff line number Diff line change
Expand Up @@ -715,7 +715,7 @@ bool ParseHEVCCodecId(const std::string& codec_id,
}
#endif

#if BUILDFLAG(ENABLE_DOLBY_VISION_DEMUXING)
#if BUILDFLAG(ENABLE_PLATFORM_DOLBY_VISION)
bool IsDolbyVisionAVCCodecId(const std::string& codec_id) {
return base::StartsWith(codec_id, "dva1.", base::CompareCase::SENSITIVE) ||
base::StartsWith(codec_id, "dvav.", base::CompareCase::SENSITIVE);
Expand Down Expand Up @@ -854,7 +854,7 @@ VideoCodec StringToVideoCodec(const std::string& codec_id) {
if (ParseHEVCCodecId(codec_id, &profile, &level))
return kCodecHEVC;
#endif
#if BUILDFLAG(ENABLE_DOLBY_VISION_DEMUXING)
#if BUILDFLAG(ENABLE_PLATFORM_DOLBY_VISION)
if (ParseDolbyVisionCodecId(codec_id, &profile, &level))
return kCodecDolbyVision;
#endif
Expand Down
2 changes: 1 addition & 1 deletion media/base/video_codecs.h
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ MEDIA_EXPORT bool ParseHEVCCodecId(const std::string& codec_id,
uint8_t* level_idc);
#endif

#if BUILDFLAG(ENABLE_DOLBY_VISION_DEMUXING)
#if BUILDFLAG(ENABLE_PLATFORM_DOLBY_VISION)
MEDIA_EXPORT bool ParseDolbyVisionCodecId(const std::string& codec_id,
VideoCodecProfile* profile,
uint8_t* level_id);
Expand Down
2 changes: 1 addition & 1 deletion media/base/video_codecs_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -582,7 +582,7 @@ TEST(ParseHEVCCodecIdTest, InvalidHEVCCodecIds) {
}
#endif

#if BUILDFLAG(ENABLE_DOLBY_VISION_DEMUXING)
#if BUILDFLAG(ENABLE_PLATFORM_DOLBY_VISION)
TEST(ParseDolbyVisionCodecIdTest, InvalidDolbyVisionCodecIds) {
VideoCodecProfile profile = VIDEO_CODEC_PROFILE_UNKNOWN;
uint8_t level_id = 0;
Expand Down
6 changes: 3 additions & 3 deletions media/ffmpeg/ffmpeg_common.cc
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ AudioCodec CodecIDToAudioCodec(AVCodecID codec_id) {
switch (codec_id) {
case AV_CODEC_ID_AAC:
return kCodecAAC;
#if BUILDFLAG(ENABLE_AC3_EAC3_AUDIO_DEMUXING)
#if BUILDFLAG(ENABLE_PLATFORM_AC3_EAC3_AUDIO)
case AV_CODEC_ID_AC3:
return kCodecAC3;
case AV_CODEC_ID_EAC3:
Expand Down Expand Up @@ -341,7 +341,7 @@ bool AVCodecContextToAudioDecoderConfig(
// not fill |sample_fmt|.
case kCodecAC3:
case kCodecEAC3:
#if BUILDFLAG(ENABLE_AC3_EAC3_AUDIO_DEMUXING)
#if BUILDFLAG(ENABLE_PLATFORM_AC3_EAC3_AUDIO)
// The spec for AC3/EAC3 audio is ETSI TS 102 366. According to sections
// F.3.1 and F.5.1 in that spec the sample_format for AC3/EAC3 must be 16.
sample_format = kSampleFormatS16;
Expand Down Expand Up @@ -382,7 +382,7 @@ bool AVCodecContextToAudioDecoderConfig(
if (channel_layout == CHANNEL_LAYOUT_DISCRETE)
config->SetChannelsForDiscrete(codec_context->channels);

#if BUILDFLAG(ENABLE_AC3_EAC3_AUDIO_DEMUXING)
#if BUILDFLAG(ENABLE_PLATFORM_AC3_EAC3_AUDIO)
// These are bitstream formats unknown to ffmpeg, so they don't have
// a known sample format size.
if (codec == kCodecAC3 || codec == kCodecEAC3)
Expand Down
4 changes: 2 additions & 2 deletions media/filters/ffmpeg_demuxer_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1384,7 +1384,7 @@ TEST_F(FFmpegDemuxerTest, HEVC_in_MP4_container) {

TEST_F(FFmpegDemuxerTest, Read_AC3_Audio) {
CreateDemuxer("bear-ac3-only-frag.mp4");
#if BUILDFLAG(ENABLE_AC3_EAC3_AUDIO_DEMUXING)
#if BUILDFLAG(ENABLE_PLATFORM_AC3_EAC3_AUDIO)
// AC3 is not supported by default media platform. Embedders who add support
// must declare it via MediaClient.
MockMediaClient media_client;
Expand Down Expand Up @@ -1414,7 +1414,7 @@ TEST_F(FFmpegDemuxerTest, Read_AC3_Audio) {

TEST_F(FFmpegDemuxerTest, Read_EAC3_Audio) {
CreateDemuxer("bear-eac3-only-frag.mp4");
#if BUILDFLAG(ENABLE_AC3_EAC3_AUDIO_DEMUXING)
#if BUILDFLAG(ENABLE_PLATFORM_AC3_EAC3_AUDIO)
// EAC3 is not supported by default media platform. Embedders who add support
// must declare it via MediaClient.
MockMediaClient media_client;
Expand Down
24 changes: 12 additions & 12 deletions media/filters/stream_parser_factory.cc
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ static const CodecInfo kHEVCHEV1CodecInfo = {
static const CodecInfo kHEVCHVC1CodecInfo = {
"hvc1.*", CodecInfo::VIDEO, nullptr, CodecInfo::HISTOGRAM_HEVC};
#endif // BUILDFLAG(ENABLE_PLATFORM_HEVC)
#if BUILDFLAG(ENABLE_DOLBY_VISION_DEMUXING)
#if BUILDFLAG(ENABLE_PLATFORM_DOLBY_VISION)
static const CodecInfo kDolbyVisionAVCCodecInfo1 = {
"dva1.*", CodecInfo::VIDEO, nullptr, CodecInfo::HISTOGRAM_DOLBYVISION};
static const CodecInfo kDolbyVisionAVCCodecInfo2 = {
Expand All @@ -180,14 +180,14 @@ static const CodecInfo kDolbyVisionHEVCCodecInfo1 = {
static const CodecInfo kDolbyVisionHEVCCodecInfo2 = {
"dvhe.*", CodecInfo::VIDEO, nullptr, CodecInfo::HISTOGRAM_DOLBYVISION};
#endif // BUILDFLAG(ENABLE_PLATFORM_HEVC)
#endif // BUILDFLAG(ENABLE_DOLBY_VISION_DEMUXING)
#endif // BUILDFLAG(ENABLE_PLATFORM_DOLBY_VISION)
static const CodecInfo kMPEG4AACCodecInfo = {"mp4a.40.*", CodecInfo::AUDIO,
&ValidateMP4ACodecID,
CodecInfo::HISTOGRAM_MPEG4AAC};
static const CodecInfo kMPEG2AACLCCodecInfo = {
"mp4a.67", CodecInfo::AUDIO, nullptr, CodecInfo::HISTOGRAM_MPEG2AAC};

#if BUILDFLAG(ENABLE_AC3_EAC3_AUDIO_DEMUXING)
#if BUILDFLAG(ENABLE_PLATFORM_AC3_EAC3_AUDIO)
// The 'ac-3' and 'ec-3' are mime codec ids for AC3 and EAC3 according to
// http://www.mp4ra.org/codecs.html
// The object types for AC3 and EAC3 in MP4 container are 0xa5 and 0xa6, so
Expand All @@ -206,9 +206,9 @@ static const CodecInfo kEAC3CodecInfo2 = {"mp4a.a6", CodecInfo::AUDIO, nullptr,
CodecInfo::HISTOGRAM_EAC3};
static const CodecInfo kEAC3CodecInfo3 = {"mp4a.A6", CodecInfo::AUDIO, nullptr,
CodecInfo::HISTOGRAM_EAC3};
#endif // BUILDFLAG(ENABLE_AC3_EAC3_AUDIO_DEMUXING)
#endif // BUILDFLAG(ENABLE_PLATFORM_AC3_EAC3_AUDIO)

#if BUILDFLAG(ENABLE_MPEG_H_AUDIO_DEMUXING)
#if BUILDFLAG(ENABLE_PLATFORM_MPEG_H_AUDIO)
static const CodecInfo kMpegHAudioCodecInfo1 = {
"mhm1.*", CodecInfo::AUDIO, nullptr, CodecInfo::HISTOGRAM_MPEG_H_AUDIO};
static const CodecInfo kMpegHAudioCodecInfo2 = {
Expand Down Expand Up @@ -241,7 +241,7 @@ static const CodecInfo* const kVideoMP4Codecs[] = {&kMPEG4FLACCodecInfo,
&kHEVCHEV1CodecInfo,
&kHEVCHVC1CodecInfo,
#endif
#if BUILDFLAG(ENABLE_DOLBY_VISION_DEMUXING)
#if BUILDFLAG(ENABLE_PLATFORM_DOLBY_VISION)
&kDolbyVisionAVCCodecInfo1,
&kDolbyVisionAVCCodecInfo2,
#if BUILDFLAG(ENABLE_PLATFORM_HEVC)
Expand All @@ -251,7 +251,7 @@ static const CodecInfo* const kVideoMP4Codecs[] = {&kMPEG4FLACCodecInfo,
#endif
&kMPEG4AACCodecInfo,
&kMPEG2AACLCCodecInfo,
#if BUILDFLAG(ENABLE_MPEG_H_AUDIO_DEMUXING)
#if BUILDFLAG(ENABLE_PLATFORM_MPEG_H_AUDIO)
&kMpegHAudioCodecInfo1,
&kMpegHAudioCodecInfo2,
#endif
Expand All @@ -266,18 +266,18 @@ static const CodecInfo* const kAudioMP4Codecs[] = {&kMPEG4FLACCodecInfo,
#if BUILDFLAG(USE_PROPRIETARY_CODECS)
&kMPEG4AACCodecInfo,
&kMPEG2AACLCCodecInfo,
#if BUILDFLAG(ENABLE_MPEG_H_AUDIO_DEMUXING)
#if BUILDFLAG(ENABLE_PLATFORM_MPEG_H_AUDIO)
&kMpegHAudioCodecInfo1,
&kMpegHAudioCodecInfo2,
#endif
#if BUILDFLAG(ENABLE_AC3_EAC3_AUDIO_DEMUXING)
#if BUILDFLAG(ENABLE_PLATFORM_AC3_EAC3_AUDIO)
&kAC3CodecInfo1,
&kAC3CodecInfo2,
&kAC3CodecInfo3,
&kEAC3CodecInfo1,
&kEAC3CodecInfo2,
&kEAC3CodecInfo3,
#endif // BUILDFLAG(ENABLE_AC3_EAC3_AUDIO_DEMUXING)
#endif // BUILDFLAG(ENABLE_PLATFORM_AC3_EAC3_AUDIO)
#endif // BUILDFLAG(USE_PROPRIETARY_CODECS)
nullptr};

Expand Down Expand Up @@ -312,7 +312,7 @@ static StreamParser* BuildMP4Parser(const std::vector<std::string>& codecs,
has_sbr = true;
break;
}
#if BUILDFLAG(ENABLE_AC3_EAC3_AUDIO_DEMUXING)
#if BUILDFLAG(ENABLE_PLATFORM_AC3_EAC3_AUDIO)
} else if (base::MatchPattern(codec_id, kAC3CodecInfo1.pattern) ||
base::MatchPattern(codec_id, kAC3CodecInfo2.pattern) ||
base::MatchPattern(codec_id, kAC3CodecInfo3.pattern)) {
Expand All @@ -321,7 +321,7 @@ static StreamParser* BuildMP4Parser(const std::vector<std::string>& codecs,
base::MatchPattern(codec_id, kEAC3CodecInfo2.pattern) ||
base::MatchPattern(codec_id, kEAC3CodecInfo3.pattern)) {
audio_object_types.insert(mp4::kEAC3);
#endif // BUILDFLAG(ENABLE_AC3_EAC3_AUDIO_DEMUXING)
#endif // BUILDFLAG(ENABLE_PLATFORM_AC3_EAC3_AUDIO)
#endif // BUILDFLAG(USE_PROPRIETARY_CODECS)
}
}
Expand Down
4 changes: 2 additions & 2 deletions media/formats/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ source_set("formats") {
]
}

if (proprietary_codecs && enable_dolby_vision_demuxing) {
if (proprietary_codecs && enable_platform_dolby_vision) {
sources += [
"mp4/dolby_vision.cc",
"mp4/dolby_vision.h",
Expand Down Expand Up @@ -255,7 +255,7 @@ source_set("unit_tests") {
]
}

if (enable_dolby_vision_demuxing) {
if (enable_platform_dolby_vision) {
sources += [ "mp4/dolby_vision_unittest.cc" ]
}

Expand Down
Loading

0 comments on commit 23236dc

Please sign in to comment.