Update Chromoting to use /third_party/closure_compiler.

This cl updates the checker.py script in /third_party/closure_compiler to
add an option to process a set of JS files at once rather than one at a
time (the current default). It also adds a flag to enable additional compiler
checks (since Chromoting wants all checks enabled).

It also updates the Chromoting .gyp files to make use of the new compiler.

The remaining changes were motivated by the errors reported by the new
closure compiler.

BUG=

Review URL: https://codereview.chromium.org/803653004

Cr-Commit-Position: refs/heads/master@{#311531}

remoting/app_remoting_webapp_build.gypi

@@ -258,7 +258,6 @@
               'success_stamp': '<(PRODUCT_DIR)/>(_target_name)_main_jscompile.stamp',
             },
             'inputs': [
-              'tools/jscompile.py',
               '<@(ar_main_js_files)',
               '<@(remoting_webapp_js_proto_files)',
               # Include zip as input so that this action is run after the build.
@@ -268,11 +267,12 @@
               '<(success_stamp)',
             ],
             'action': [
-              'python', 'tools/jscompile.py',
+              'python', '../third_party/closure_compiler/checker.py',
+              '--strict',
+              '--no-single-file',
+              '--success-stamp', '<(success_stamp)',
               '<@(ar_main_js_files)',
               '<@(remoting_webapp_js_proto_files)',
-              '--success-stamp',
-              '<(success_stamp)'
             ],
           },
           {
@@ -281,7 +281,6 @@
               'success_stamp': '<(PRODUCT_DIR)/>(_target_name)_background_jscompile.stamp',
             },
             'inputs': [
-              'tools/jscompile.py',
               '<@(ar_background_js_files)',
               '<@(remoting_webapp_js_proto_files)',
               # Include zip as input so that this action is run after the build.
@@ -291,11 +290,12 @@
               '<(success_stamp)',
             ],
             'action': [
-              'python', 'tools/jscompile.py',
+              'python', '../third_party/closure_compiler/checker.py',
+              '--strict',
+              '--no-single-file',
+              '--success-stamp', '<(success_stamp)',
               '<@(ar_background_js_files)',
               '<@(remoting_webapp_js_proto_files)',
-              '--success-stamp',
-              '<(success_stamp)'
             ],
           },
         ],  # actions

remoting/remoting_webapp.gypi

@@ -34,10 +34,12 @@
             '<(success_stamp)',
           ],
           'action': [
-            'python', 'tools/jscompile.py',
+            'python', '../third_party/closure_compiler/checker.py',
+            '--strict',
+            '--no-single-file',
+            '--success-stamp', '<(success_stamp)',
             '<@(remoting_webapp_crd_js_files)',
             '<@(remoting_webapp_js_proto_files)',
-            '--success-stamp', '<(success_stamp)'
           ],
         },
       ],  # actions

remoting/remoting_webapp_files.gypi

@@ -14,7 +14,6 @@
     # These provide type information for jscompile.
     'remoting_webapp_js_proto_files': [
       'webapp/js_proto/chrome_proto.js',
-      'webapp/js_proto/console_proto.js',
       'webapp/js_proto/dom_proto.js',
       'webapp/js_proto/remoting_proto.js',
     ],
@@ -167,8 +166,8 @@
     ],
     # The unit test cases for the webapp
     'remoting_webapp_unittest_js_files': [
-      'webapp/js_proto/chrome_proto.js',
       'webapp/unittests/chrome_mocks.js',
+      'webapp/js_proto/chrome_proto.js',
       'webapp/unittests/base_unittest.js',
       'webapp/unittests/it2me_helpee_channel_unittest.js',
       'webapp/unittests/it2me_helper_channel_unittest.js',

remoting/webapp/app_remoting/js/app_remoting.js

@@ -240,7 +240,7 @@ remoting.AppRemoting.prototype.handleConnected = function(clientSession) {
   // Cancel the ping when the connection closes.
   clientSession.addEventListener(
       remoting.ClientSession.Events.stateChanged,
-      /** @param {remoting.ClientSession.StateEvent} state */
+      /** @param {remoting.ClientSession.StateEvent=} state */
       function(state) {
         if (state.current === remoting.ClientSession.State.CLOSED ||
             state.current === remoting.ClientSession.State.FAILED) {

remoting/webapp/app_remoting/js/application_context_menu.js

@@ -65,7 +65,7 @@ remoting.ApplicationContextMenu.prototype.updateConnectionRTT =
                                  rttText));
 };
 
-/** @param {OnClickData} info */
+/** @param {OnClickData=} info */
 remoting.ApplicationContextMenu.prototype.onClicked_ = function(info) {
   switch (info.menuItemId) {
 

remoting/webapp/app_remoting/js/context_menu_adapter.js

@@ -50,7 +50,7 @@ remoting.ContextMenuAdapter.prototype.remove = function(id) {
 };
 
 /**
- * @param {function(OnClickData):void} listener
+ * @param {function(OnClickData=):void} listener
  */
 remoting.ContextMenuAdapter.prototype.addListener = function(listener) {
 };

remoting/webapp/app_remoting/js/context_menu_dom.js

@@ -41,24 +41,24 @@ remoting.ContextMenuDom = function(root) {
    * @private
    */
   this.stub_ = /** @type {HTMLElement} */
-      this.root_.querySelector('.context-menu-stub');
+      (this.root_.querySelector('.context-menu-stub'));
   /**
    * @type {HTMLElement}
    * @private
    */
   this.icon_ = /** @type {HTMLElement} */
-      this.root_.querySelector('.context-menu-icon');
+      (this.root_.querySelector('.context-menu-icon'));
   /**
    * @type {HTMLElement}
    * @private
    */
   this.screen_ = /** @type {HTMLElement} */
-      this.root_.querySelector('.context-menu-screen');
+      (this.root_.querySelector('.context-menu-screen'));
   /**
    * @type {HTMLElement}
    * @private
    */
-  this.menu_ = /** @type {HTMLElement} */ this.root_.querySelector('ul');
+  this.menu_ = /** @type {HTMLElement} */ (this.root_.querySelector('ul'));
   /**
    * @type {number}
    * @private
@@ -84,7 +84,7 @@ remoting.ContextMenuDom = function(root) {
    */
   this.stubDragged_ = false;
 
-  /*
+  /**
    * @private
    */
   this.dragAndDrop_ = new remoting.DragAndDrop(
@@ -194,7 +194,7 @@ remoting.ContextMenuDom.prototype.remove = function(id) {
 };
 
 /**
- * @param {function(OnClickData):void} listener
+ * @param {function(OnClickData=):void} listener
  */
 remoting.ContextMenuDom.prototype.addListener = function(listener) {
   this.eventSource_.addEventListener(this.eventName_, listener);

remoting/webapp/app_remoting/js/drag_and_drop.js

@@ -61,13 +61,13 @@ remoting.DragAndDrop = function(element, dragUpdate,
   this.seenNonZeroDelta_ = false;
 
   /**
-   * @type {function():void}
+   * @type {function(Event):void}
    * @private
    */
   this.callOnMouseUp_ = this.onMouseUp_.bind(this);
 
   /**
-   * @type {function():void}
+   * @type {function(Event):void}
    * @private
    */
   this.callOnMouseMove_ = this.onMouseMove_.bind(this);
@@ -139,4 +139,4 @@ remoting.DragAndDrop.prototype.onMouseUp_ = function(event) {
   if (this.dragEnd_) {
     this.dragEnd_();
   }
-};
+};

remoting/webapp/app_remoting/js/keyboard_layouts_menu.js

@@ -166,7 +166,7 @@ remoting.KeyboardLayoutsMenu.prototype.makeMenuId_ = function(layout) {
 /**
  * Handle a click on the application's context menu.
  *
- * @param {OnClickData} info
+ * @param {OnClickData=} info
  * @private
  */
 remoting.KeyboardLayoutsMenu.prototype.onContextMenu_ = function(info) {

remoting/webapp/app_remoting/js/window_activation_menu.js

@@ -66,7 +66,7 @@ remoting.WindowActivationMenu.prototype.makeMenuId_ = function(windowId) {
 /**
  * Handle a click on the application's context menu.
  *
- * @param {OnClickData} info
+ * @param {OnClickData=} info
  * @private
  */
 remoting.WindowActivationMenu.prototype.onContextMenu_ = function(info) {

remoting/webapp/base/js/application.js

@@ -114,7 +114,7 @@ remoting.Application.prototype.onVideoStreamingStarted = function() {
  * @return {boolean} Return true if the extension message was recognized.
  */
 remoting.Application.prototype.onExtensionMessage = function(type, data) {
-  var message = /** @type {Object} */base.jsonParseSafe(data);
+  var message = /** @type {Object} */ (base.jsonParseSafe(data));
   if (typeof message != 'object') {
     return false;
   }

remoting/webapp/base/js/base.js

@@ -46,8 +46,7 @@ base.debug.assert = function(expr, opt_msg) {
 base.debug.callstack = function() {
   try {
     throw new Error();
-  } catch (e) {
-    var error = /** @type {Error} */ e;
+  } catch (/** @type {Error} */ error) {
     var callstack = error.stack
       .replace(/^\s+(at eval )?at\s+/gm, '') // Remove 'at' and indentation.
       .split('\n');
@@ -91,7 +90,7 @@ base.mix = function(dest, src) {
  * Adds a mixin to a class.
  * @param {Object} dest
  * @param {Object} src
- * @suppress {checkTypes}
+ * @suppress {checkTypes|reportUnknownTypes}
  */
 base.extend = function(dest, src) {
   base.mix(dest.prototype, src.prototype || src);
@@ -195,32 +194,32 @@ base.escapeHTML = function(str) {
  */
 base.Deferred = function() {
   /**
-   * @type {?function(?=)}
+   * @type {?function(?):void}
    * @private
    */
   this.resolve_ = null;
 
   /**
-   * @type {?function(?)}
+   * @type {?function(?):void}
    * @private
    */
   this.reject_ = null;
 
+  /**
+   * @this {base.Deferred}
+   * @param {function(?):void} resolve
+   * @param {function(*):void} reject
+   */
+  var initPromise = function(resolve, reject) {
+    this.resolve_ = resolve;
+    this.reject_ = reject;
+  };
+
   /**
    * @type {Promise}
    * @private
    */
-  this.promise_ = new Promise(
-    /**
-     * @param {function(?=):void} resolve
-     * @param {function(?):void} reject
-     * @this {base.Deferred}
-     */
-    function(resolve, reject) {
-      this.resolve_ = resolve;
-      this.reject_ = reject;
-    }.bind(this)
-  );
+  this.promise_ = new Promise(initPromise.bind(this));
 };
 
 /** @param {*} reason */
@@ -246,7 +245,7 @@ base.Promise = function() {};
  */
 base.Promise.sleep = function(delay) {
   return new Promise(
-    /** @param {function():void} fulfill */
+    /** @param {function(*):void} fulfill */
     function(fulfill) {
       window.setTimeout(fulfill, delay);
     });
@@ -436,11 +435,12 @@ base.generateXsrfToken = function() {
 
 /**
  * @param {string} jsonString A JSON-encoded string.
- * @return {*} The decoded object, or undefined if the string cannot be parsed.
+ * @return {Object|undefined} The decoded object, or undefined if the string
+ *     cannot be parsed.
  */
 base.jsonParseSafe = function(jsonString) {
   try {
-    return JSON.parse(jsonString);
+    return /** @type {Object} */ (JSON.parse(jsonString));
   } catch (err) {
     return undefined;
   }

remoting/webapp/base/js/message_window.js

@@ -125,15 +125,17 @@ MessageWindowImpl.prototype.onMessage_ = function(event) {
         infoboxDiv.hidden = true;
       }
 
+      var messageIdStr = messageId.toString();
+
       this.initButton_(
           button,
           buttonLabel,
-          this.sendReply_.bind(this, event.source, messageId, 1));
+          this.sendReply_.bind(this, event.source, messageIdStr, 1));
 
       this.initButton_(
           cancelButton,
           cancelButtonLabel,
-          this.sendReply_.bind(this, event.source, messageId, 0));
+          this.sendReply_.bind(this, event.source, messageIdStr, 0));
 
       var buttonToFocus = (cancelButtonLabel) ? cancelButton : button;
       buttonToFocus.focus();
@@ -143,7 +145,7 @@ MessageWindowImpl.prototype.onMessage_ = function(event) {
       // Note that when a button is pressed, this will result in sendReply_
       // being called multiple times (once for the button, once for close).
       chrome.app.window.current().onClosed.addListener(
-          this.sendReply_.bind(this, event.source, messageId, 0));
+          this.sendReply_.bind(this, event.source, messageIdStr, 0));
 
       this.updateSize_();
       chrome.app.window.current().show();