Feedback: Localize explore app title on confirmation page

* Add screenshot and hash for exploreAppTitle string. * Screenshot: http://screen/jKw92MAGEgBWWar Bug: b:185624798 Test: browser_tests --gtest_filter=OSFeedbackBrowserTest.* Change-Id: Ib99925abfd8c44448aa5ae45d97ecde0ca1972ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3710812 Reviewed-by: Xiangdong Kong <xiangdongkong@google.com> Commit-Queue: Longbo Wei <longbowei@google.com> Cr-Commit-Position: refs/heads/main@{#1016791}
Denger-Network · Jun 22, 2022 · 23a5e4c · 23a5e4c
1 parent 39be17d
commit 23a5e4c
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 1 deletion.
diff --git a/ash/webui/os_feedback_ui/os_feedback_ui.cc b/ash/webui/os_feedback_ui/os_feedback_ui.cc
@@ -64,6 +64,7 @@ void AddLocalizedStrings(content::WebUIDataSource* source) {
       {"confirmationTitleOnline", IDS_FEEDBACK_TOOL_PAGE_TITLE_AFTER_SENT},
       {"exploreAppDescription",
        IDS_FEEDBACK_TOOL_RESOURCES_EXPLORE_APP_DESCRIPTION},
+      {"exploreAppLabel", IDS_FEEDBACK_TOOL_RESOURCES_EXPLORE_APP_LABEL},
       {"diagnosticsAppLabel",
        IDS_FEEDBACK_TOOL_RESOURCES_DIAGNOSTICS_APP_LABEL},
       {"diagnosticsAppDescription",

diff --git a/ash/webui/os_feedback_ui/resources/confirmation_page.html b/ash/webui/os_feedback_ui/resources/confirmation_page.html
@@ -29,7 +29,7 @@ <h1 class="page-title">[[getTitle_(sendReportStatus)]]</h1>
     <div id="helpResources">
       <p id="helpResourcesLabel">Here are some other helpful resources:</p>
       <cr-link-row id="explore" start-icon="help-resources:explore"
-          label="Explore app" external
+          label="[[i18n('exploreAppLabel')]]" external
           sub-label="[[i18n('exploreAppDescription')]]"
           on-click="handleLinkClicked_">
       </cr-link-row>

diff --git a/chrome/test/data/webui/chromeos/os_feedback_ui/confirmation_page_test.js b/chrome/test/data/webui/chromeos/os_feedback_ui/confirmation_page_test.js
@@ -105,6 +105,7 @@ export function confirmationPageTest() {
     assertEquals(
         'help-resources:explore', getElement(exploreLink, '#startIcon').icon);
     assertEquals('Explore app', getElementContent(exploreLink, '#label'));
+    assertTrue(page.i18nExists('exploreAppLabel'));
     assertEquals(
         'Find help articles and answers to common Chromebook questions',
         getElementContent(exploreLink, '#subLabel'));

diff --git a/chromeos/chromeos_strings.grd b/chromeos/chromeos_strings.grd
@@ -3444,6 +3444,9 @@ Try tapping the mic to ask me anything.
       <message name="IDS_FEEDBACK_TOOL_RESOURCES_EXPLORE_APP_DESCRIPTION" desc="Description of the explore app that links to some resourses like help articals and new features of Chromebook.">
         Find help articles and answers to common Chromebook questions
       </message>
+      <message name="IDS_FEEDBACK_TOOL_RESOURCES_EXPLORE_APP_LABEL" desc="Label of the explore app">
+        Explore app
+      </message>
       <message name="IDS_FEEDBACK_TOOL_RESOURCES_DIAGNOSTICS_APP_LABEL" desc="Label of the diagnostics app">
         Diagnostics app
       </message>

diff --git a/chromeos/chromeos_strings_grd/IDS_FEEDBACK_TOOL_RESOURCES_EXPLORE_APP_LABEL.png.sha1 b/chromeos/chromeos_strings_grd/IDS_FEEDBACK_TOOL_RESOURCES_EXPLORE_APP_LABEL.png.sha1
@@ -0,0 +1 @@
+75d105b9a764c40f7d5fc6e14af81f2addad3270