Skip to content

Commit

Permalink
[webview] Document browser process name for crashes.
Browse files Browse the repository at this point in the history
Change-Id: Ia3add86b7cab7697b5f48f6412932563cbd8af2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901084
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713545}
  • Loading branch information
folded authored and Commit Bot committed Nov 7, 2019
1 parent cc673fd commit 24c258e
Showing 1 changed file with 10 additions and 4 deletions.
14 changes: 10 additions & 4 deletions android_webview/common/crash_reporter/aw_crash_reporter_client.cc
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,16 @@ class AwCrashReporterClient : public crash_reporter::CrashReporterClient {
}

bool GetBrowserProcessType(std::string* ptype) override {
*ptype = base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kWebViewSandboxedRenderer)
? "browser"
: "webview";
if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kWebViewSandboxedRenderer)) {
// In single process mode the renderer and browser are in the same
// process. The process type is "webview" to distinguish this case,
// and for backwards compatibility.
*ptype = "webview";
} else {
// Otherwise, in multi process mode, "browser" suffices.
*ptype = "browser";
}
return true;
}

Expand Down

0 comments on commit 24c258e

Please sign in to comment.