Skip to content

Commit

Permalink
Update chrome-proxy platforms
Browse files Browse the repository at this point in the history
The video tests needs to be mapped to the actual desktop platforms,
additionally I split up the platforms into desktop/webview groups
rather than safebrowsing.

BUG=508701

Review URL: https://codereview.chromium.org/1229143003

Cr-Commit-Position: refs/heads/master@{#338176}
  • Loading branch information
bustamante authored and Commit bot committed Jul 9, 2015
1 parent 717c436 commit 25b75ce
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions tools/chrome_proxy/integration_tests/chrome_proxy_benchmark.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
from integration_tests import chrome_proxy_pagesets as pagesets
from telemetry import benchmark

NON_SAFE_BROWSING_BROWSERS = ['mac', 'linux', 'win', 'chromeos',
'android-webview', 'android-webview-shell']
DESKTOP_PLATFORMS = ['mac', 'linux', 'win', 'chromeos']
WEBVIEW_PLATFORMS = ['android-webview', 'android-webview-shell']

class ChromeProxyClientVersion(ChromeProxyBenchmark):
tag = 'client_version'
Expand Down Expand Up @@ -90,7 +90,7 @@ def Name(cls):
return 'chrome_proxy_benchmark.block_once.block_once'


@benchmark.Disabled(*NON_SAFE_BROWSING_BROWSERS)
@benchmark.Disabled(*(DESKTOP_PLATFORMS + WEBVIEW_PLATFORMS))
# Safebrowsing is enabled for Android and iOS.
class ChromeProxySafeBrowsingOn(ChromeProxyBenchmark):
tag = 'safebrowsing_on'
Expand All @@ -107,7 +107,7 @@ def Name(cls):
return 'chrome_proxy_benchmark.safebrowsing_on.safebrowsing'


@benchmark.Enabled(*NON_SAFE_BROWSING_BROWSERS)
@benchmark.Enabled(*(DESKTOP_PLATFORMS + WEBVIEW_PLATFORMS))
# Safebrowsing is switched off for Android Webview and all desktop platforms.
class ChromeProxySafeBrowsingOff(ChromeProxyBenchmark):
tag = 'safebrowsing_off'
Expand Down Expand Up @@ -180,7 +180,7 @@ def Name(cls):
return 'chrome_proxy_benchmark.client_config.synthetic'


@benchmark.Enabled('desktop')
@benchmark.Enabled(*DESKTOP_PLATFORMS)
class ChromeProxyVideoDirect(benchmark.Benchmark):
tag = 'video'
test = measurements.ChromeProxyVideoValidation
Expand All @@ -191,7 +191,7 @@ def Name(cls):
return 'chrome_proxy_benchmark.video.direct'


@benchmark.Enabled('desktop')
@benchmark.Enabled(*DESKTOP_PLATFORMS)
class ChromeProxyVideoProxied(benchmark.Benchmark):
tag = 'video'
test = measurements.ChromeProxyVideoValidation
Expand All @@ -202,7 +202,7 @@ def Name(cls):
return 'chrome_proxy_benchmark.video.proxied'


@benchmark.Enabled('desktop')
@benchmark.Enabled(*DESKTOP_PLATFORMS)
class ChromeProxyVideoCompare(benchmark.Benchmark):
"""Comparison of direct and proxied video fetches.
Expand All @@ -218,7 +218,7 @@ class ChromeProxyVideoCompare(benchmark.Benchmark):
def Name(cls):
return 'chrome_proxy_benchmark.video.compare'

@benchmark.Enabled('desktop')
@benchmark.Enabled(*DESKTOP_PLATFORMS)
class ChromeProxyVideoFrames(benchmark.Benchmark):
"""Check for video frames similar to original video."""

Expand All @@ -230,7 +230,7 @@ class ChromeProxyVideoFrames(benchmark.Benchmark):
def Name(cls):
return 'chrome_proxy_benchmark.video.frames'

@benchmark.Enabled('desktop')
@benchmark.Enabled(*DESKTOP_PLATFORMS)
class ChromeProxyVideoAudio(benchmark.Benchmark):
"""Check that audio is similar to original video."""

Expand Down

0 comments on commit 25b75ce

Please sign in to comment.