Skip to content

Commit

Permalink
Removing few unused methods from CompositorView
Browse files Browse the repository at this point in the history
This change takes care of removing onLayout, surfaceRedrawNeeded
methods and few and unused members from CompositorView.

BUG=

Review URL: https://codereview.chromium.org/1638303009

Cr-Commit-Position: refs/heads/master@{#372642}
  • Loading branch information
ajith.v authored and Commit bot committed Feb 1, 2016
1 parent fc620d8 commit 2973c23
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 17 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
*/
@JNINamespace("chrome::android")
public class CompositorView
extends SurfaceView implements ContentOffsetProvider, SurfaceHolder.Callback2 {
extends SurfaceView implements ContentOffsetProvider, SurfaceHolder.Callback {
private static final String TAG = "CompositorView";

// Cache objects that should not be created every frame
Expand Down Expand Up @@ -145,11 +145,6 @@ && getMeasuredHeight() > MeasureSpec.getSize(heightMeasureSpec)) {
super.onMeasure(widthMeasureSpec, heightMeasureSpec);
}

@Override
protected void onLayout(boolean changed, int left, int top, int right, int bottom) {
super.onLayout(changed, left, top, right, bottom);
}

@Override
protected void onDetachedFromWindow() {
super.onDetachedFromWindow();
Expand Down Expand Up @@ -238,9 +233,6 @@ public void surfaceDestroyed(SurfaceHolder holder) {
nativeSurfaceDestroyed(mNativeCompositorView);
}

@Override
public void surfaceRedrawNeeded(SurfaceHolder holder) {}

@Override
public void onWindowVisibilityChanged(int visibility) {
super.onWindowVisibilityChanged(visibility);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
import android.util.AttributeSet;
import android.util.Pair;
import android.view.MotionEvent;
import android.view.SurfaceHolder;
import android.view.SurfaceView;
import android.view.View;
import android.view.ViewGroup;
Expand Down Expand Up @@ -262,13 +261,6 @@ public void setControlContainer(ControlContainer controlContainer) {
}
}

/**
* @return The CompositorView.
*/
public SurfaceHolder.Callback2 getSurfaceHolderCallback2() {
return mCompositorView;
}

/**
* Reset command line flags. This gets called after the native library finishes
* loading.
Expand Down

0 comments on commit 2973c23

Please sign in to comment.