Skip to content

Commit

Permalink
Remove/replace unnecessary includes of logging.h (pdf/)
Browse files Browse the repository at this point in the history
If the file just needs the CHECK/CHECK_OP/NOTREACHED
macros, use the appropriate header for that instead.
Or if logging.h is not needed at all, remove it.

This is both a nice cleanup (logging.h is a big header,
and including it unnecessarily has compile-time costs),
and part of the final step towards making logging.h no
longer include check.h and the others.

Bug: 1031540
Change-Id: Id0f04386d2024d6646d7bc05761954eeedd1e338
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254779
Commit-Queue: Lei Zhang <thestig@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780810}
  • Loading branch information
zmodem authored and Commit Bot committed Jun 22, 2020
1 parent a9f454e commit 29adea9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pdf/document_layout.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
#include <cstddef>
#include <vector>

#include "base/logging.h"
#include "base/check_op.h"
#include "pdf/draw_utils/coordinates.h"
#include "pdf/page_orientation.h"
#include "ppapi/cpp/rect.h"
Expand Down

0 comments on commit 29adea9

Please sign in to comment.