Skip to content

Commit

Permalink
Remove "or is_macosx" from toolkit_views in .grd
Browse files Browse the repository at this point in the history
'is_macosx' imples toolkit_views now so this is redundant.

Bug: None
Change-Id: I99579cf7aa48ad15c8a83b167d1f2d0181c73a64
Reviewed-on: https://chromium-review.googlesource.com/930366
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538586}
  • Loading branch information
pbos authored and Commit Bot committed Feb 22, 2018
1 parent 21497e5 commit 2a6e5e6
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion chrome/app/chromium_strings.grd
Original file line number Diff line number Diff line change
Expand Up @@ -706,7 +706,7 @@ Signing in anyway will merge Chromium information like bookmarks, history, and o
</if>

<!-- Enterprise sign-in dialog -->
<if expr="toolkit_views or is_macosx">
<if expr="toolkit_views">
<message name="IDS_ENTERPRISE_SIGNIN_TITLE" desc="The title of the dialog to confirm linking the browser profile with the signed-in enterprise account">
Link your Chromium data to this account?
</message>
Expand Down
2 changes: 1 addition & 1 deletion chrome/app/generated_resources.grd
Original file line number Diff line number Diff line change
Expand Up @@ -8425,7 +8425,7 @@ Please help our engineers fix this problem. Tell us what happened right before y
</if>

<!-- Translate Bubble -->
<if expr="toolkit_views or is_macosx">
<if expr="toolkit_views">
<message name="IDS_TRANSLATE_BUBBLE_BEFORE_TRANSLATE_TITLE" desc="Title text for the translate bubble when asking to translate a page.">
Translate this page?
</message>
Expand Down
2 changes: 1 addition & 1 deletion chrome/app/google_chrome_strings.grd
Original file line number Diff line number Diff line change
Expand Up @@ -716,7 +716,7 @@ Signing in anyway will merge Chrome information like bookmarks, history, and oth
</if>

<!-- Enterprise sign-in dialog -->
<if expr="toolkit_views or is_macosx">
<if expr="toolkit_views">
<message name="IDS_ENTERPRISE_SIGNIN_TITLE" desc="The title of the dialog to confirm linking the browser profile with the signed-in enterprise account">
Link your Chrome data to this account?
</message>
Expand Down
6 changes: 3 additions & 3 deletions chrome/app/theme/theme_resources.grd
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
<structure type="chrome_scaled_image" name="IDR_APP_WINDOW_MINIMIZE_L" file="common/app_window_minimize_light.png" />
<structure type="chrome_scaled_image" name="IDR_APP_WINDOW_MINIMIZE_P" file="common/app_window_minimize_active.png" />
</if>
<if expr="toolkit_views or is_macosx">
<if expr="toolkit_views">
<structure type="chrome_scaled_image" name="IDR_BACK" file="common/browser_back_normal.png" />
<structure type="chrome_scaled_image" name="IDR_BACK_D" file="common/browser_back_disabled.png" />
<structure type="chrome_scaled_image" name="IDR_BACK_H" file="common/browser_back_hover.png" />
Expand Down Expand Up @@ -145,7 +145,7 @@
</if>
<structure type="chrome_scaled_image" name="IDR_FIRST_RUN_COMPLETION" file="cros/first_run_completion.png" />
</if>
<if expr="toolkit_views or is_macosx">
<if expr="toolkit_views">
<structure type="chrome_scaled_image" name="IDR_FORWARD" file="common/browser_forward_normal.png" />
<structure type="chrome_scaled_image" name="IDR_FORWARD_D" file="common/browser_forward_disabled.png" />
<structure type="chrome_scaled_image" name="IDR_FORWARD_H" file="common/browser_forward_hover.png" />
Expand Down Expand Up @@ -363,7 +363,7 @@
<structure type="chrome_scaled_image" name="IDR_AVATAR_NATIVE_BUTTON_PRESSED_TOP" file="win/avatar_button/win8/sign_in_button_pressed_top.png" />
<structure type="chrome_scaled_image" name="IDR_AVATAR_NATIVE_BUTTON_PRESSED_TOP_LEFT" file="win/avatar_button/win8/sign_in_button_pressed_top_left.png" />
<structure type="chrome_scaled_image" name="IDR_AVATAR_NATIVE_BUTTON_PRESSED_TOP_RIGHT" file="win/avatar_button/win8/sign_in_button_pressed_top_right.png" />
</if> <!-- toolkit_views and not is_macosx -->
</if>
<if expr="chromeos">
<structure type="chrome_scaled_image" name="IDR_RESET_WARNING" file="cros/reset_warning.png" />
</if>
Expand Down
2 changes: 1 addition & 1 deletion ui/resources/ui_resources.grd
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@
<structure type="chrome_scaled_image" name="IDR_MENU_HIERARCHY_ARROW" file="mac/menu_hierarchy_arrow.png" />
</if>
<structure type="chrome_scaled_image" name="IDR_MENU_DROPARROW" file="cros/menu_droparrow.png" />
<if expr="toolkit_views or is_macosx or is_ios">
<if expr="toolkit_views or is_ios">
<if expr="is_win">
<structure type="chrome_scaled_image" name="IDR_NOTIFICATION_CLOSE" file="win/notification_close.png"/>
<structure type="chrome_scaled_image" name="IDR_NOTIFICATION_CLOSE_HOVER" file="win/notification_close_hover.png"/>
Expand Down

0 comments on commit 2a6e5e6

Please sign in to comment.