forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
shortcuts: Add aria-label and role for shortcut key icons
This CL improves the usability of the shortcuts app for screen readers by adding role=img and an aria-label to each shortcut key icon. Previously, ChromeVox would skip over icons and not read their name, or read the key name (e.g. "ZoomToggle" for fullscreen). I also added a test that goes through and checks that each string ID in keyToIconNameMap has been loaded into the WebUI. Bug: b:216049298 Test: browser_tests ShortcutCustomizationApp* Change-Id: I62d2d042ef03e0854b3d771542c7743671a78527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4153154 Commit-Queue: Camden Bickel <cambickel@google.com> Reviewed-by: Michael Checo <michaelcheco@google.com> Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/main@{#1091931}
- Loading branch information
Cam Bickel
authored and
Chromium LUCI CQ
committed
Jan 12, 2023
1 parent
6cbf428
commit 2af853c
Showing
5 changed files
with
178 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters