Skip to content

Commit

Permalink
Remove the CrosHealthdMetricsProvider
Browse files Browse the repository at this point in the history
This provider is preventing the AsyncInit task from ever completing,
which is causing a major drop-off in Chrome OS metrics.

Bug: b:165076656
Change-Id: I4d8a700b3b11a6cb9db4fddeebc75e5484a0d137
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368142
Auto-Submit: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Weilun Shi <sweilun@chromium.org>
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800444}
  • Loading branch information
ishermandom authored and Commit Bot committed Aug 21, 2020
1 parent f1d2948 commit 2c8a348
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
4 changes: 0 additions & 4 deletions chrome/browser/metrics/chrome_metrics_service_client.cc
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,6 @@
#include "chrome/browser/metrics/ambient_mode_metrics_provider.h"
#include "chrome/browser/metrics/assistant_service_metrics_provider.h"
#include "chrome/browser/metrics/chromeos_metrics_provider.h"
#include "chrome/browser/metrics/cros_healthd_metrics_provider.h"
#include "chrome/browser/signin/signin_status_metrics_provider_chromeos.h"
#include "components/metrics/structured/structured_metrics_provider.h"
#endif
Expand Down Expand Up @@ -709,9 +708,6 @@ void ChromeMetricsServiceClient::RegisterMetricsServiceProviders() {
std::make_unique<ChromeOSMetricsProvider>(
metrics::MetricsLogUploader::UMA));

metrics_service_->RegisterMetricsProvider(
std::make_unique<CrosHealthdMetricsProvider>());

metrics_service_->RegisterMetricsProvider(
std::make_unique<SigninStatusMetricsProviderChromeOS>());

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -177,10 +177,10 @@ TEST_F(ChromeMetricsServiceClientTest, TestRegisterMetricsServiceProviders) {

#if defined(OS_CHROMEOS)
// AmbientModeMetricsProvider, AssistantServiceMetricsProvider,
// CrosHealthdMetricsProvider, ChromeOSMetricsProvider,
// ChromeOSMetricsProvider,
// SigninStatusMetricsProviderChromeOS, PrinterMetricsProvider, and
// HashedLoggingMetricsProvider.
expected_providers += 7;
expected_providers += 6;
#endif // defined(OS_CHROMEOS)

#if !defined(OS_CHROMEOS)
Expand Down

0 comments on commit 2c8a348

Please sign in to comment.