Skip to content

Commit

Permalink
Revert "remove SK_SUPPORT_LEGACY_COLORFILTER_FILTERSPAN"
Browse files Browse the repository at this point in the history
This reverts commit 6699312.

Reason for revert:

This has caused multiple layout tests to start failing consistently. For example:

* editing/surrounding-text/surrounding-text.html
* fast/forms/calendar-picker/calendar-picker-appearance-zoom200.html
* http/tests/inspector/extensions/extensions-panel.html
* virtual/mojo-loading/http/tests/inspector/extensions/extensions-panel.html

https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.9/builds/47590
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win10/builds/23257
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests/builds/58651

Original change's description:
> remove SK_SUPPORT_LEGACY_COLORFILTER_FILTERSPAN
> 
> Bug: 
> Change-Id: Ib2cd8827f316845e60b0b183bc5a596e39715532
> Reviewed-on: https://chromium-review.googlesource.com/548536
> Commit-Queue: Mike Reed <reed@chromium.org>
> Reviewed-by: Florin Malita <fmalita@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#482711}

TBR=fmalita@chromium.org,reed@chromium.org,herb@chromium.org,mtklein@chromium.org

Change-Id: I73839f7ef3876cc51ae3eed142167f13692a457a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/551137
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482844}
  • Loading branch information
Ben Wells authored and Commit Bot committed Jun 28, 2017
1 parent 2f0699b commit 2e0a873
Show file tree
Hide file tree
Showing 775 changed files with 108 additions and 457 deletions.
4 changes: 4 additions & 0 deletions skia/config/SkUserConfig.h
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,10 @@ SK_API void SkDebugf_FileLine(const char* file, int line, bool fatal,
# define SK_USE_LEGACY_DISTANCE_FIELDS
#endif

#ifndef SK_SUPPORT_LEGACY_COLORFILTER_FILTERSPAN
#define SK_SUPPORT_LEGACY_COLORFILTER_FILTERSPAN
#endif

#ifndef SK_DISABLE_DEFERRED_PROXIES
#define SK_DISABLE_DEFERRED_PROXIES
#endif
Expand Down
2 changes: 0 additions & 2 deletions third_party/WebKit/LayoutTests/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -1998,8 +1998,6 @@ crbug.com/736056 external/wpt/encoding/legacy-mb-tchinese/big5/big5-encode-href.
# rebaseline-cl does not handle ref-tests yet...
crbug.com/736811 fast/css/text-overflow-ellipsis-multiple-shadows.html [ Pass Failure ]
crbug.com/736811 external/wpt/css/selectors4/focus-within-004.html [ Pass Failure ]
crbug.com/736811 fast/canvas/canvas-fillPath-gradient-shadow.html [ Pass Failure ]
crbug.com/736811 virtual/display_list_2d_canvas/fast/canvas/canvas-fillPath-gradient-shadow.html [ Pass Failure ]

# Failures in non-wpt tests from:
# https://chromium-review.googlesource.com/c/543695/
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

This file was deleted.

This file was deleted.

Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.

This file was deleted.

Diff not rendered.
Diff not rendered.
Loading

0 comments on commit 2e0a873

Please sign in to comment.