Skip to content

Commit

Permalink
Include-what-you-use related to logging.h (ppapi)
Browse files Browse the repository at this point in the history
Add direct includes for things provided transitively by logging.h
(or by other headers including logging.h).

This is in preparation for cleaning up unnecessary includes of
logging.h in header files (so if something depends on logging.h,
it needs include it explicitly), and for when logging.h no longer
includes check.h, check_op.h, and notreached.h.

Bug: 1031540
Change-Id: Icaa271ea7e32c0494a7b3f578696e397e7cd0a48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249675
Commit-Queue: Hans Wennborg <hans@chromium.org>
Commit-Queue: Bill Budge <bbudge@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779331}
  • Loading branch information
zmodem authored and Commit Bot committed Jun 17, 2020
1 parent 22bfb42 commit 2e85796
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions ppapi/proxy/raw_var_data.cc
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
#include "ppapi/proxy/raw_var_data.h"

#include "base/containers/stack.h"
#include "base/logging.h"
#include "base/memory/ptr_util.h"
#include "base/memory/unsafe_shared_memory_region.h"
#include "base/stl_util.h"
Expand Down
1 change: 1 addition & 0 deletions ppapi/shared_impl/resource_tracker.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

#include "base/bind.h"
#include "base/compiler_specific.h"
#include "base/logging.h"
#include "base/memory/ptr_util.h"
#include "ppapi/shared_impl/callback_tracker.h"
#include "ppapi/shared_impl/id_assignment.h"
Expand Down
1 change: 1 addition & 0 deletions ppapi/thunk/ppb_graphics_3d_thunk.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

#include <stdint.h>

#include "base/logging.h"
#include "ppapi/c/pp_completion_callback.h"
#include "ppapi/c/pp_errors.h"
#include "ppapi/c/ppb_graphics_3d.h"
Expand Down

0 comments on commit 2e85796

Please sign in to comment.