forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add PRESUBMIT check to cc to ensure that C++ std::abs is used
Before this patch, it is possible to use abs() without the std:: namespace qualifier, which may link to the C standard library implementation of abs(). Thus, someone using abs(float) may get wrong results because C standard version will convert the float to an int. This patch updates the occurrences of of abs() and fabs() in cc/ (though technically none were incorrect, thankfully) and adds a PRESUBMIT to enforce that all uses of abs from now on have an explicit std:: to resolve them correctly. BUG=261900 R=enne@chromium.org Review URL: https://codereview.chromium.org/19835003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214144 0039d316-1c4b-4281-b951-d872f2087c98
- Loading branch information
shawnsingh@google.com
committed
Jul 28, 2013
1 parent
e6f97e7
commit 2f3aca1
Showing
7 changed files
with
53 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters