Skip to content

Commit

Permalink
Align Webauthn OWNERS.
Browse files Browse the repository at this point in the history 
Balazs will be focusing elsewhere in the future, but was a cornerstone
of the OWNERS for Webauthn code. This change uses //device/fido/OWNERS
to define a Webauthn “group” and references that file in several places.

Change-Id: I8cc4d203a519669253fce0f5c82537e44ec331af
Reviewed-on: https://chromium-review.googlesource.com/c/1284437
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600597}
  • Loading branch information
Adam Langley authored and Commit Bot committed Oct 17, 2018
1 parent c51a63f commit 301234b
Show file tree
Hide file tree
Showing 13 changed files with 44 additions and 37 deletions.
3 changes: 2 additions & 1 deletion chrome/android/java/src/org/chromium/chrome/browser/webauth/OWNERS
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
kpaulhamus@chromium.org

# COMPONENT: Blink>WebAuthentication
# COMPONENT: Blink>WebAuthentication
# TEAM: identity-dev@chromium.org
3 changes: 2 additions & 1 deletion chrome/android/javatests/src/org/chromium/chrome/browser/webauth/OWNERS
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
kpaulhamus@chromium.org

# COMPONENT: Blink>WebAuthentication
# COMPONENT: Blink>WebAuthentication
# TEAM: identity-dev@chromium.org
4 changes: 1 addition & 3 deletions chrome/app/theme/default_100_percent/common/webauthn/OWNERS
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
engedy@chromium.org
hongjunchoi@chromium.org
kpaulhamus@chromium.org
file://device/fido/OWNERS

# Component: Blink>WebAuthentication
# TEAM: identity-dev@chromium.org
4 changes: 1 addition & 3 deletions chrome/app/theme/default_200_percent/common/webauthn/OWNERS
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
engedy@chromium.org
hongjunchoi@chromium.org
kpaulhamus@chromium.org
file://device/fido/OWNERS

# Component: Blink>WebAuthentication
# TEAM: identity-dev@chromium.org
9 changes: 4 additions & 5 deletions chrome/browser/extensions/api/cryptotoken_private/OWNERS
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
agl@chromium.org
mab@chromium.org
kpaulhamus@chromium.org
arnarb@chromium.org
juanlang@chromium.org
file://device/fido/OWNERS

# TEAM: identity-dev@chromium.org
# COMPONENT: Blink>WebAuthentication
5 changes: 2 additions & 3 deletions chrome/browser/ui/views/webauthn/OWNERS
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
engedy@chromium.org
kpaulhamus@chromium.org
file://device/fido/OWNERS

# TEAM: security-dev@chromium.org
# TEAM: identity-dev@chromium.org
# COMPONENT: Blink>WebAuthentication
5 changes: 2 additions & 3 deletions chrome/browser/ui/webauthn/OWNERS
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
engedy@chromium.org
kpaulhamus@chromium.org
file://device/fido/OWNERS

# TEAM: security-dev@chromium.org
# TEAM: identity-dev@chromium.org
# COMPONENT: Blink>WebAuthentication
5 changes: 2 additions & 3 deletions chrome/browser/webauthn/OWNERS
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
engedy@chromium.org
kpaulhamus@chromium.org
file://device/fido/OWNERS

# Component: Blink>WebAuthentication
# TEAM: identity-dev@chromium.org
# Component: Blink>WebAuthentication
6 changes: 2 additions & 4 deletions content/browser/webauth/OWNERS
View file
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
engedy@chromium.org
file://device/fido/OWNERS
mkwst@chromium.org
kpaulhamus@chromium.org
hongjunchoi@chromium.org

per-file *_type_converter*.*=set noparent
per-file *_type_converter*.*=file://ipc/SECURITY_OWNERS

# Component: Blink>WebAuthentication
# TEAM: identity-dev@chromium.org
# Component: Blink>WebAuthentication
23 changes: 19 additions & 4 deletions device/fido/OWNERS
View file
Original file line number Diff line number Diff line change
@@ -1,8 +1,23 @@
reillyg@chromium.org
jdoerrie@chromium.org
engedy@chromium.org
# Webauthn OWNERS

# General, esp chrome/ UI and Android integration.
kpaulhamus@chromium.org

# General, esp U2F and CTAP2 code.
hongjunchoi@chromium.org

# TEAM: security-dev@chromium.org
# TouchID, Windows Hello.
martinkr@chromium.org

# Bluetooth.
jdoerrie@chromium.org

# Attestation and legacy U2F implementation.
agl@chromium.org

# Emeritus; for occasional reviews, esp those in the depths of view & frame
# lifetimes.
engedy@chromium.org

# TEAM: identity-dev@chromium.org
# COMPONENT: Blink>WebAuthentication
5 changes: 2 additions & 3 deletions device/fido/mac/OWNERS
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
martinkr@chromium.org
martinkr@google.com
file://device/fido/OWNERS

# TEAM: security-dev@chromium.org
# COMPONENT: Blink>WebAuthentication
# TEAM: identity-dev@chromium.org
5 changes: 3 additions & 2 deletions third_party/WebKit/LayoutTests/external/wpt/webauthn/OWNERS
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# TEAM: security-dev@chromium.org
# COMPONENT: Blink>WebAuthentication
kpaulhamus@chromium.org

# COMPONENT: Blink>WebAuthentication
# TEAM: identity-dev@chromium.org
4 changes: 2 additions & 2 deletions third_party/blink/renderer/modules/credentialmanager/OWNERS
View file
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
engedy@chromium.org
mkwst@chromium.org
vasilii@chromium.org
file://device/fido/OWNERS

per-file *_type_converter*.*=set noparent
per-file *_type_converter*.*=file://ipc/SECURITY_OWNERS

# COMPONENT: Blink>SecurityFeature>CredentialManagement
# TEAM: identity-dev@chromium.org
# COMPONENT: Blink>SecurityFeature>CredentialManagement

0 comments on commit 301234b

Please sign in to comment.