Skip to content

Commit

Permalink
[gin ] Migrate to new-style V8 callbacks
Browse files Browse the repository at this point in the history
Change-Id: Ib50dbd2d3785cb5e72a5dd8381db8d7220a86446
Reviewed-on: https://chromium-review.googlesource.com/803475
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521346}
  • Loading branch information
camillobruni authored and Commit Bot committed Dec 4, 2017
1 parent 2087f0b commit 3097ab4
Showing 1 changed file with 7 additions and 8 deletions.
15 changes: 7 additions & 8 deletions gin/object_template_builder.cc
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ IndexedPropertyInterceptor* IndexedInterceptorFromV8(
return PerIsolateData::From(isolate)->GetIndexedPropertyInterceptor(base);
}

void NamedPropertyGetter(v8::Local<v8::String> property,
void NamedPropertyGetter(v8::Local<v8::Name> property,
const v8::PropertyCallbackInfo<v8::Value>& info) {
v8::Isolate* isolate = info.GetIsolate();
NamedPropertyInterceptor* interceptor =
Expand All @@ -61,7 +61,7 @@ void NamedPropertyGetter(v8::Local<v8::String> property,
info.GetReturnValue().Set(interceptor->GetNamedProperty(isolate, name));
}

void NamedPropertySetter(v8::Local<v8::String> property,
void NamedPropertySetter(v8::Local<v8::Name> property,
v8::Local<v8::Value> value,
const v8::PropertyCallbackInfo<v8::Value>& info) {
v8::Isolate* isolate = info.GetIsolate();
Expand All @@ -75,7 +75,7 @@ void NamedPropertySetter(v8::Local<v8::String> property,
info.GetReturnValue().Set(value);
}

void NamedPropertyQuery(v8::Local<v8::String> property,
void NamedPropertyQuery(v8::Local<v8::Name> property,
const v8::PropertyCallbackInfo<v8::Integer>& info) {
v8::Isolate* isolate = info.GetIsolate();
NamedPropertyInterceptor* interceptor =
Expand Down Expand Up @@ -151,11 +151,10 @@ ObjectTemplateBuilder::ObjectTemplateBuilder(
ObjectTemplateBuilder::~ObjectTemplateBuilder() = default;

ObjectTemplateBuilder& ObjectTemplateBuilder::AddNamedPropertyInterceptor() {
template_->SetNamedPropertyHandler(&NamedPropertyGetter,
&NamedPropertySetter,
&NamedPropertyQuery,
NULL,
&NamedPropertyEnumerator);
template_->SetHandler(v8::NamedPropertyHandlerConfiguration(
&NamedPropertyGetter, &NamedPropertySetter, &NamedPropertyQuery, nullptr,
&NamedPropertyEnumerator, v8::Local<v8::Value>(),
v8::PropertyHandlerFlags::kOnlyInterceptStrings));
return *this;
}

Expand Down

0 comments on commit 3097ab4

Please sign in to comment.