clang plugin: Remove enforce-in-pdf toggle.

Flipped on in r413689.

Review-Url: https://codereview.chromium.org/2268203002
Cr-Commit-Position: refs/heads/master@{#413772}

tools/clang/plugins/ChromeClassTester.cpp

@@ -224,10 +224,6 @@ void ChromeClassTester::BuildBannedLists() {
     allowed_directories_.emplace("/third_party/WebKit/");
   }
 
-  if (!options_.enforce_in_pdf) {
-    banned_directories_.emplace("/pdf/");
-  }
-
   banned_directories_.emplace("/third_party/");
   banned_directories_.emplace("/native_client/");
   banned_directories_.emplace("/breakpad/");

tools/clang/plugins/FindBadConstructsAction.cpp

@@ -48,7 +48,8 @@ bool FindBadConstructsAction::ParseArgs(const CompilerInstance& instance,
       // TODO(rsleevi): Remove this once http://crbug.com/123295 is fixed.
       options_.check_base_classes = true;
     } else if (args[i] == "enforce-in-pdf") {
-      options_.enforce_in_pdf = true;
+      // TODO(thestig): This is now always on. Remove support for this flag once
+      // the build no longer passes it in.
     } else if (args[i] == "enforce-in-thirdparty-webkit") {
       options_.enforce_in_thirdparty_webkit = true;
     } else if (args[i] == "check-enum-last-value") {

tools/clang/plugins/Options.h

@@ -9,7 +9,6 @@ namespace chrome_checker {
 
 struct Options {
   bool check_base_classes = false;
-  bool enforce_in_pdf = false;
   bool enforce_in_thirdparty_webkit = false;  // Use in Blink code itself
   bool check_enum_last_value = false;
   // This is needed for some distributed build-sytems to respect banned