extensions: Remove dependency on chrome's common target.

Now that installer does not need extensions' constant (removed in
r268166) we can finally build constants.* within extensions_common target.

BUG=368334
TEST=green trybots
R=yoz@chromium.org
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/270233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268968 0039d316-1c4b-4281-b951-d872f2087c98

chrome/common_constants.gyp

@@ -13,9 +13,6 @@
 
   'target_defaults': {
     'sources': [
-      # TODO(yoz): Create an extension_constants target for these.
-      '../extensions/common/constants.cc',
-      '../extensions/common/constants.h',
       'common/chrome_constants.cc',
       'common/chrome_constants.h',
       'common/chrome_icon_resources_win.cc',

extensions/extensions.gyp

@@ -15,9 +15,6 @@
         # api resources compiled into the chrome resource bundle.
         # http://crbug.com/162530
         '../chrome/chrome_resources.gyp:chrome_resources',
-        # TODO(tfarina): This dep here is for extensions/common/constants.*
-        # We should find a way to compile this module within extensions_common.
-        '../chrome/common_constants.gyp:common_constants',
         '../components/components.gyp:url_matcher',
         '../content/content.gyp:content_common',
         '../crypto/crypto.gyp:crypto',
@@ -46,6 +43,8 @@
         'common/api/sockets/sockets_manifest_permission.h',
         'common/common_manifest_handlers.cc',
         'common/common_manifest_handlers.h',
+        'common/constants.cc',
+        'common/constants.h',
         'common/crx_file.cc',
         'common/crx_file.h',
         'common/csp_validator.cc',