Skip to content

Commit

Permalink
Remove dead Shell::CreateNewWindowWithSessionStorageNamespace()
Browse files Browse the repository at this point in the history
R=avi@chromium.org

Bug: 866140
Change-Id: I5f582807e4c8243d740f2dc4f83fb8a481ec242a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240044
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777239}
  • Loading branch information
danakj authored and Commit Bot committed Jun 11, 2020
1 parent 9a3da7d commit 33d80a8
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 32 deletions.
25 changes: 0 additions & 25 deletions content/shell/browser/shell.cc
Original file line number Diff line number Diff line change
Expand Up @@ -227,31 +227,6 @@ Shell* Shell::CreateNewWindow(BrowserContext* browser_context,
return shell;
}

Shell* Shell::CreateNewWindowWithSessionStorageNamespace(
BrowserContext* browser_context,
const GURL& url,
const scoped_refptr<SiteInstance>& site_instance,
const gfx::Size& initial_size,
scoped_refptr<SessionStorageNamespace> session_storage_namespace) {
WebContents::CreateParams create_params(browser_context, site_instance);
if (base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kForcePresentationReceiverForTesting)) {
create_params.starting_sandbox_flags =
content::kPresentationReceiverSandboxFlags;
}
std::map<std::string, scoped_refptr<SessionStorageNamespace>>
session_storages;
session_storages[""] = session_storage_namespace;
std::unique_ptr<WebContents> web_contents =
WebContents::CreateWithSessionStorage(create_params, session_storages);
Shell* shell =
CreateShell(std::move(web_contents), AdjustWindowSize(initial_size),
true /* should_set_delegate */);
if (!url.is_empty())
shell->LoadURL(url);
return shell;
}

void Shell::RenderViewReady() {
g_platform->RenderViewReady(this);
}
Expand Down
7 changes: 0 additions & 7 deletions content/shell/browser/shell.h
Original file line number Diff line number Diff line change
Expand Up @@ -72,13 +72,6 @@ class Shell : public WebContentsDelegate,
const scoped_refptr<SiteInstance>& site_instance,
const gfx::Size& initial_size);

static Shell* CreateNewWindowWithSessionStorageNamespace(
BrowserContext* browser_context,
const GURL& url,
const scoped_refptr<SiteInstance>& site_instance,
const gfx::Size& initial_size,
scoped_refptr<SessionStorageNamespace> session_storage_namespace);

// Returns the Shell object corresponding to the given WebContents.
static Shell* FromWebContents(WebContents* web_contents);

Expand Down

0 comments on commit 33d80a8

Please sign in to comment.