Skip to content

Commit

Permalink
Fix nits in PDF date parser tests
Browse files Browse the repository at this point in the history
Bug: 93619
Change-Id: I6c63eb0381d2a005e224d83b3075fcae9fab9ab8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629671
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Commit-Queue: K. Moon <kmoon@chromium.org>
Auto-Submit: Daniel Hosseinian <dhoss@chromium.org>
Reviewed-by: K. Moon <kmoon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843678}
  • Loading branch information
Daniel Hosseinian authored and Chromium LUCI CQ committed Jan 14, 2021
1 parent 355e694 commit 3423b77
Showing 1 changed file with 13 additions and 3 deletions.
16 changes: 13 additions & 3 deletions pdf/pdf_utils/dates_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ TEST(DatesTest, ParsePdfDateBadPrefix) {

TEST(DatesTest, ParsePdfDateNoValidYear) {
EXPECT_PRED1(IsInvalidPdfDate, "");
EXPECT_PRED1(IsInvalidPdfDate, "");
EXPECT_PRED1(IsInvalidPdfDate, "D:");
EXPECT_PRED1(IsInvalidPdfDate, "D:999");
}

Expand Down Expand Up @@ -100,15 +100,25 @@ TEST(DatesTest, ParsePdfDateWithTimeOffset) {
ASSERT_TRUE(base::Time::FromUTCString("2020-06-04 10:11:20", &expected));
EXPECT_EQ(ParsePdfDate("D:20200604214120+11'30"), expected);

ASSERT_TRUE(base::Time::FromUTCString("2020-06-04 14:56:20", &expected));
EXPECT_EQ(ParsePdfDate("D:20200604214120+06'45'"), expected);
}

TEST(DatesTest, ParsePdfDateTruncatedOffset) {
base::Time expected;

ASSERT_TRUE(base::Time::FromUTCString("2020-06-04 21:41:20", &expected));
EXPECT_EQ(ParsePdfDate("D:20200604214120+6'45'"), expected);

ASSERT_TRUE(base::Time::FromUTCString("2020-06-04 15:41:20", &expected));
EXPECT_EQ(ParsePdfDate("D:20200604214120+06'4'"), expected);
}

TEST(DatesTest, ParsePdfDateWithSecondsOffset) {
// Seconds offset is not supported.
base::Time expected;
ASSERT_TRUE(base::Time::FromUTCString("2020-06-04 21:41:20", &expected));
EXPECT_EQ(ParsePdfDate("D:20200604214120+6'45'56'"), expected);
ASSERT_TRUE(base::Time::FromUTCString("2020-06-04 14:56:20", &expected));
EXPECT_EQ(ParsePdfDate("D:20200604214120+06'45'56'"), expected);
}

TEST(DatesTest, ParsePdfDateWithTimeOffsetNoApostrophe) {
Expand Down

0 comments on commit 3423b77

Please sign in to comment.