Skip to content

Commit

Permalink
Reland of Change default Windows compiler to VS 2015 (patchset chromi…
Browse files Browse the repository at this point in the history 
…um#1 id:1 of https://codereview.chromium.org/1680533004/ )

Reason for revert:
The GPU bot problem (a bug with swarming tests on component builds) is fixed with crrev.com/1676943002

Original issue's description:
> Revert of Change default Windows compiler to VS 2015 (patchset chromium#1 id:1 of https://codereview.chromium.org/1679693002/ )
>
> Reason for revert:
> This breaks GPU win debug bots (https://build.chromium.org/p/chromium.gpu/builders/Win7%20Debug%20%28NVIDIA%29/builds/36633 for example, every GPU test is crashing)
>
> Original issue's description:
> > Reland of Change default Windows compiler to VS 2015 (patchset chromium#1 id:1 of https://codereview.chromium.org/1678663002/ )
> >
> > Reason for revert:
> > Issues that forced revert of VS 2015 as default compiler are believed to be fixed.
> >
> > Original issue's description:
> > > Revert of Change default Windows compiler to VS 2015 (patchset chromium#10 id:180001 of https://codereview.chromium.org/1598493004/ )
> > >
> > > Reason for revert:
> > > Speculative for https://code.google.com/p/chromium/issues/detail?id=498544#c20 . Will reland if this doesn't help.
> > >
> > > Original issue's description:
> > > > Change default Windows compiler to VS 2015
> > > >
> > > > The change to get_landmines.py is there because modifying this file
> > > > affects analyze behavior so that all tests run. Changing the printed
> > > > message is purely a side effect.
> > > >
> > > > This change also removes some redundant INCLUDE paths. These are
> > > > unnecessary when building with VS 2015 (because it defaults to the
> > > > Windows 10 SDK) and actively harmful (they make the INCLUDE path
> > > > problematically long).
> > > >
> > > > BUG=440500,584782
> > > >
> > > > Committed: https://crrev.com/4c17ac0db59d7dbe78734950f83912ab564bd6fe
> > > > Cr-Commit-Position: refs/heads/master@{#373955}
> > >
> > > TBR=dpranke@chromium.org,scottmg@chromium.org,sebmarchand@chromium.org,brucedawson@chromium.org
> > > # Skipping CQ checks because original CL landed less than 1 days ago.
> > > NOPRESUBMIT=true
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=440500,584782
> > >
> > > Committed: https://crrev.com/bbc766aef1bd8cb0d9546fec9abf264e7d8c1d96
> > > Cr-Commit-Position: refs/heads/master@{#374013}
> >
> > TBR=dpranke@chromium.org,scottmg@chromium.org,sebmarchand@chromium.org,thakis@chromium.org
> > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > BUG=440500,584782
> >
> > Committed: https://crrev.com/20e99ecb08da22582d435c1a5bba0a5c96345da3
> > Cr-Commit-Position: refs/heads/master@{#374058}
>
> TBR=dpranke@chromium.org,scottmg@chromium.org,sebmarchand@chromium.org,thakis@chromium.org,brucedawson@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=440500,584782
>
> Committed: https://crrev.com/03f6b0af0a3a0127f5e939095157079659ab7cc8
> Cr-Commit-Position: refs/heads/master@{#374062}

TBR=dpranke@chromium.org,scottmg@chromium.org,sebmarchand@chromium.org,thakis@chromium.org,zmo@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=440500,584782

Review URL: https://codereview.chromium.org/1676263003

Cr-Commit-Position: refs/heads/master@{#374324}
  • Loading branch information
@randomascii
randomascii authored and Commit bot committed Feb 9, 2016
1 parent 25634af commit 36f03f2
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 22 deletions.
10 changes: 6 additions & 4 deletions build/common.gypi
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5670,11 +5670,13 @@
],
}],
],
# Add extra include directories here that need to be in front of the
# installed and packaged include directories. This may be needed in
# order to force a particular SDK version, such as to get VS 2013 to use
# the Windows 10 SDK. Beware of making the INCLUDE variable excessively
# long, and be sure to make corresponding changes to
# build\toolchain\win\setup_toolchain.py
'msvs_system_include_dirs': [
'<(windows_sdk_path)/Include/10.0.10586.0/shared',
'<(windows_sdk_path)/Include/10.0.10586.0/um',
'<(windows_sdk_path)/Include/10.0.10586.0/winrt',
'$(VSInstallDir)/VC/atlmfc/include',
],
'msvs_cygwin_shell': 0,
'msvs_disabled_warnings': [
Expand Down
4 changes: 1 addition & 3 deletions build/get_landmines.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,7 @@ def print_landmines():
print "Switched win x64 trybots from VS2010 to VS2012."
if (platform() == 'win' and builder() == 'ninja' and
gyp_msvs_version().startswith('2013')):
print "Switched win from VS2010 to VS2013."
print "Update to VS2013 Update 2."
print "Update to VS2013 Update 4."
print "Switch to VS2013"
if (platform() == 'win' and gyp_msvs_version().startswith('2015')):
print 'Switch to VS2015'
print 'Need to clobber everything due to an IDL change in r154579 (blink)'
Expand Down
22 changes: 10 additions & 12 deletions build/toolchain/win/setup_toolchain.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -150,18 +150,16 @@ def main():
vc_bin_dir = os.path.realpath(path)
break

# The Windows SDK include directories must be first. They both have a sal.h,
# and the SDK one is newer and the SDK uses some newer features from it not
# present in the Visual Studio one.
# Having the Windows SDK first is also the only way to control which SDK
# version is used.

if win_sdk_path:
additional_includes = ('{sdk_dir}\\Include\\10.0.10586.0\\shared;' +
'{sdk_dir}\\Include\\10.0.10586.0\\um;' +
'{sdk_dir}\\Include\\10.0.10586.0\\winrt;').format(
sdk_dir=win_sdk_path)
env['INCLUDE'] = additional_includes + env['INCLUDE']
# Add extra include directories here that need to be in front of the
# installed and packaged include directories. This may be needed in
# order to force a particular SDK version, such as to get VS 2013 to use
# the Windows 10 SDK. Beware of making the INCLUDE variable excessively
# long and be sure to make corresponding changes to build\common.gypi.
# Not currently used.
#if win_sdk_path:
# additional_includes = ('{sdk_dir}\\Include\\10.0.10586.0\\um;').format(
# sdk_dir=win_sdk_path)
# env['INCLUDE'] = additional_includes + env['INCLUDE']
env_block = _FormatAsEnvironmentBlock(env)
with open('environment.' + cpu, 'wb') as f:
f.write(env_block)
Expand Down
8 changes: 5 additions & 3 deletions build/vs_toolchain.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
import gyp


# Use MSVS2013 as the default toolchain.
CURRENT_DEFAULT_TOOLCHAIN_VERSION = '2013'
# Use MSVS2015 as the default toolchain.
CURRENT_DEFAULT_TOOLCHAIN_VERSION = '2015'


def SetEnvironmentAndGetRuntimeDllDirs():
Expand Down Expand Up @@ -281,7 +281,6 @@ def _GetDesiredVsToolchainHashes():
# Update 1 with Debuggers, UCRT installers and ucrtbased.dll
return ['523b6c2d3df300b2c8538cdc0beac404726af051']
else:
# Default to VS2013.
return ['4087e065abebdca6dbd0caca2910c6718d2ec67f']


Expand Down Expand Up @@ -315,6 +314,9 @@ def Update(force=False):
depot_tools_win_toolchain):
import find_depot_tools
depot_tools_path = find_depot_tools.add_depot_tools_to_path()
# Necessary so that get_toolchain_if_necessary.py will put the VS toolkit
# in the correct directory.
os.environ['GYP_MSVS_VERSION'] = GetVisualStudioVersion()
get_toolchain_args = [
sys.executable,
os.path.join(depot_tools_path,
Expand Down

0 comments on commit 36f03f2

Please sign in to comment.