Add a flag for go/betterAM

Add kAccountManagementFlowsV2 flag for redesign of account management flows and Account Manager page in Settings. Bug: 1144113 Change-Id: I1a5ee10afc5e51ba426d4330c571e84e44effad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526401 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#828200}
Denger-Network · Nov 17, 2020 · 3967787 · 3967787
1 parent 76fdec8
commit 3967787
Show file tree

Hide file tree

Showing 7 changed files with 33 additions and 0 deletions.
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
@@ -2698,6 +2698,10 @@ const FeatureEntry kFeatureEntries[] = {
      FEATURE_VALUE_TYPE(display::features::kUseHDRTransferFunction)},
 #endif  // OS_CHROMEOS
 #if defined(OS_CHROMEOS)
+    {"account-management-flows-v2",
+     flag_descriptions::kAccountManagementFlowsV2Name,
+     flag_descriptions::kAccountManagementFlowsV2Description, kOsCrOS,
+     FEATURE_VALUE_TYPE(chromeos::features::kAccountManagementFlowsV2)},
     {"dark-light-mode", flag_descriptions::kDarkLightTestName,
      flag_descriptions::kDarkLightTestDescription, kOsCrOS,
      FEATURE_VALUE_TYPE(ash::features::kDarkLightMode)},

diff --git a/chrome/browser/flag-metadata.json b/chrome/browser/flag-metadata.json
@@ -44,6 +44,11 @@
     "owners": [ "msarda" ],
     "expiry_milestone": 88
   },
+  {
+    "name": "account-management-flows-v2",
+    "owners": [ "anastasiian", "sinhak" ],
+    "expiry_milestone": 91
+  },
   {
     "name": "add-web-content-drop-interaction",
     "owners": [ "edchin", "bling-flags@google.com" ],

diff --git a/chrome/browser/flag_descriptions.cc b/chrome/browser/flag_descriptions.cc
@@ -3569,6 +3569,13 @@ const char kVideoToolboxVp9DecodingDescription[] =
 
 #if defined(OS_CHROMEOS)
 
+const char kAccountManagementFlowsV2Name[] =
+    "Enable redesign of account management flows";
+const char kAccountManagementFlowsV2Description[] =
+    "Enables redesign of account management flows and Account Manager page in "
+    "Settings. "
+    "See go/betterAM";
+
 const char kAcceleratedMjpegDecodeName[] =
     "Hardware-accelerated mjpeg decode for captured frame";
 const char kAcceleratedMjpegDecodeDescription[] =

diff --git a/chrome/browser/flag_descriptions.h b/chrome/browser/flag_descriptions.h
@@ -2069,6 +2069,9 @@ extern const char kVideoToolboxVp9DecodingDescription[];
 
 #if defined(OS_CHROMEOS)
 
+extern const char kAccountManagementFlowsV2Name[];
+extern const char kAccountManagementFlowsV2Description[];
+
 extern const char kAcceleratedMjpegDecodeName[];
 extern const char kAcceleratedMjpegDecodeDescription[];
 

diff --git a/chromeos/constants/chromeos_features.cc b/chromeos/constants/chromeos_features.cc
@@ -19,6 +19,11 @@ const base::Feature kInstantTetheringBackgroundAdvertisementSupport{
 
 }  // namespace
 
+// Enables redesign of account management flows.
+// https://crbug.com/1132472
+const base::Feature kAccountManagementFlowsV2{
+    "AccountManagementFlowsV2", base::FEATURE_DISABLED_BY_DEFAULT};
+
 // Shows settings for adjusting scroll acceleration/sensitivity for
 // mouse/touchpad.
 const base::Feature kAllowScrollSettings{"AllowScrollSettings",
@@ -655,6 +660,10 @@ const base::Feature kCrostiniResetLxdDb{"CrostiniResetLxdDb",
 
 ////////////////////////////////////////////////////////////////////////////////
 
+bool IsAccountManagementFlowsV2Enabled() {
+  return base::FeatureList::IsEnabled(kAccountManagementFlowsV2);
+}
+
 bool IsAmbientModeEnabled() {
   return base::FeatureList::IsEnabled(kAmbientModeFeature);
 }

diff --git a/chromeos/constants/chromeos_features.h b/chromeos/constants/chromeos_features.h
@@ -16,6 +16,8 @@ namespace features {
 // alongside the definition of their values in the .cc file. If a feature is
 // being rolled out via Finch, add a comment in the .cc file.
 
+COMPONENT_EXPORT(CHROMEOS_CONSTANTS)
+extern const base::Feature kAccountManagementFlowsV2;
 COMPONENT_EXPORT(CHROMEOS_CONSTANTS)
 extern const base::Feature kAllowScrollSettings;
 COMPONENT_EXPORT(CHROMEOS_CONSTANTS)
@@ -299,6 +301,7 @@ extern const base::Feature kCrostiniResetLxdDb;
 
 // Keep alphabetized.
 
+COMPONENT_EXPORT(CHROMEOS_CONSTANTS) bool IsAccountManagementFlowsV2Enabled();
 COMPONENT_EXPORT(CHROMEOS_CONSTANTS) bool IsAmbientModeEnabled();
 COMPONENT_EXPORT(CHROMEOS_CONSTANTS) bool IsAmbientModePhotoPreviewEnabled();
 COMPONENT_EXPORT(CHROMEOS_CONSTANTS) bool IsAmbientModeDevUseProdEnabled();

diff --git a/tools/metrics/histograms/enums.xml b/tools/metrics/histograms/enums.xml
@@ -42055,6 +42055,7 @@ from previous Chrome versions.
   <int value="-1956349722" label="disable-smooth-scrolling"/>
   <int value="-1956231275" label="ForceSpectreVariant2Mitigation:enabled"/>
   <int value="-1955923385" label="EnableGamepadButtonAxisEvents:enabled"/>
+  <int value="-1954918413" label="AccountManagementFlowsV2:disabled"/>
   <int value="-1954246274"
       label="enable-experimental-accessibility-switch-access"/>
   <int value="-1953145846" label="TargetEmbeddingLookalikes:disabled"/>
@@ -46144,6 +46145,7 @@ from previous Chrome versions.
   <int value="2000291475"
       label="AutofillEnableInfoBarAccountIndicationFooterForSyncUsers:enabled"/>
   <int value="2001505416" label="CorbAllowlistAlsoAppliesToOorCors:enabled"/>
+  <int value="2001520126" label="AccountManagementFlowsV2:enabled"/>
   <int value="2001562962"
       label="enable-manual-fallback-for-password-saving:enabled"/>
   <int value="2002573873" label="ChromeHomeMenuItemsExpandSheet:enabled"/>