Skip to content

Commit

Permalink
Update Notification and Background Sync partial interface exposure
Browse files Browse the repository at this point in the history
The ServiceWorkerRegistration base interface is exposed in all windows
and workers, so partial interfaces that extend it should define the
same.

In practice this already is the case, as our code generator does not
consider the [Exposed] attribute in this scenario.

BUG=719590

Review-Url: https://codereview.chromium.org/2866023003
Cr-Commit-Position: refs/heads/master@{#470039}
  • Loading branch information
beverloo authored and Commit bot committed May 8, 2017
1 parent 25e493b commit 3bc2a1a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// found in the LICENSE file.

[
Exposed=(Window, ServiceWorker),
Exposed=(Window,Worker),
RuntimeEnabled=BackgroundSync,
] partial interface ServiceWorkerRegistration {
[MeasureAs=BackgroundSync] readonly attribute SyncManager sync;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
// https://notifications.spec.whatwg.org/#service-worker-api

[
Exposed=(Window, ServiceWorker),
Exposed=(Window,Worker),
RuntimeEnabled=Notifications
] partial interface ServiceWorkerRegistration {
[CallWith=ScriptState, RaisesException] Promise showNotification(DOMString title, optional NotificationOptions options);
Expand Down

0 comments on commit 3bc2a1a

Please sign in to comment.