Skip to content

Commit

Permalink
Do IWYU for STL headers in various ui/ files.
Browse files Browse the repository at this point in the history
Add necessary includes for ui/ files that fail to build as a result of
local changes to base/stl_util.h. This makes future CLs to change
stl_util.h smaller.

Also remove an unused header, and put <hb.h> in the right place in
render_text_harfbuzz.h.

Change-Id: If37bce60647d676eed858b1543bddf4c5d0580fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2923137
Auto-Submit: Lei Zhang <thestig@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#887798}
  • Loading branch information
leizleiz authored and Chromium LUCI CQ committed May 31, 2021
1 parent 2b20746 commit 3c8153d
Show file tree
Hide file tree
Showing 6 changed files with 15 additions and 3 deletions.
3 changes: 3 additions & 0 deletions ui/accessibility/ax_tree_serializer.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,10 @@
#include <stdint.h>

#include <ctime>
#include <map>
#include <memory>
#include <ostream>
#include <set>
#include <unordered_set>
#include <vector>

Expand Down
1 change: 1 addition & 0 deletions ui/compositor/compositor.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

#include <memory>
#include <string>
#include <unordered_set>

#include "base/callback_forward.h"
#include "base/containers/flat_map.h"
Expand Down
2 changes: 2 additions & 0 deletions ui/events/keycodes/keysym_to_unicode.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@

#include <stddef.h>

#include <unordered_map>

#include "base/cxx17_backports.h"
#include "base/lazy_instance.h"
#include "ui/gfx/x/keysyms/keysyms.h"
Expand Down
6 changes: 4 additions & 2 deletions ui/gfx/render_text_harfbuzz.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,20 +5,22 @@
#ifndef UI_GFX_RENDER_TEXT_HARFBUZZ_H_
#define UI_GFX_RENDER_TEXT_HARFBUZZ_H_

#include <hb.h>
#include <stddef.h>
#include <stdint.h>

#include <limits>
#include <memory>
#include <string>
#include <unordered_map>
#include <utility>
#include <vector>

#include "base/macros.h"
#include "third_party/icu/source/common/unicode/ubidi.h"
#include "third_party/icu/source/common/unicode/uscript.h"
#include "ui/gfx/render_text.h"

#include <hb.h>

namespace gfx {

class Range;
Expand Down
3 changes: 3 additions & 0 deletions ui/gl/gl_version_info.cc
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@

#include "ui/gl/gl_version_info.h"

#include <map>
#include <vector>

#include "base/check_op.h"
#include "base/notreached.h"
#include "base/strings/strcat.h"
Expand Down
3 changes: 2 additions & 1 deletion ui/ozone/platform/x11/x11_clipboard_ozone.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@

#include <iterator>
#include <memory>
#include <vector>
#include <set>
#include <utility>

#include "base/bind.h"
#include "ui/base/clipboard/clipboard_constants.h"
Expand Down

0 comments on commit 3c8153d

Please sign in to comment.