Skip to content

Commit

Permalink
Make filter box placeholder text visible in dark theme
Browse files Browse the repository at this point in the history
When devtools is activated with dark theme, colors of certain elements
may be inverted from how they are defined in the stylesheet. The filter
box placeholder color was not explicitly defined in the stylesheet, so
the color inversion did not occur for the placeholder color. This fix
explicitly sets the placeholder color so it is visible in both light
and dark themes.

Bug: 1000628
Change-Id: I7ed29c3135a91b0c1f27cd51bbaeda858997138f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787337
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Jeffrey Chen <jeffreyca16@gmail.com>
Cr-Commit-Position: refs/heads/master@{#694430}
  • Loading branch information
JeffreyCA authored and Commit Bot committed Sep 6, 2019
1 parent 0491d63 commit 4044b26
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,7 @@
.styles-sidebar-pane-filter-box > input:not(:placeholder-shown) {
box-shadow: var(--focus-ring-active-shadow);
}

.styles-sidebar-pane-filter-box > input::placeholder {
color: rgba(0, 0, 0, 0.54);
}
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,10 @@
box-shadow: var(--focus-ring-active-shadow);
}

.styles-sidebar-pane-filter-box > input::placeholder {
color: rgba(0, 0, 0, 0.54);
}

.styles-section.styles-panel-hovered:not(.read-only) span.simple-selector:hover,
.styles-section.styles-panel-hovered:not(.read-only) .media-text :hover{
text-decoration: underline;
Expand Down

0 comments on commit 4044b26

Please sign in to comment.