Skip to content

Commit

Permalink
Remove implicit HANDLE conversions from elf.
Browse files Browse the repository at this point in the history
BUG=416722
R=gab@chromium.org, robertshield@chromium.org

Review URL: https://codereview.chromium.org/603803002

Cr-Commit-Position: refs/heads/master@{#296819}
  • Loading branch information
rvargas authored and Commit bot committed Sep 25, 2014
1 parent 55f6614 commit 42d5525
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions chrome_elf/create_file/chrome_create_file_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -242,8 +242,9 @@ class ChromeCreateFileTest : public PlatformTest {
}


EXPECT_FALSE(file_handle == INVALID_HANDLE_VALUE);
::WriteFile(file_handle, kTestData, buffer_size, &bytes_written, NULL);
EXPECT_TRUE(file_handle.IsValid());
::WriteFile(file_handle.Get(), kTestData, buffer_size, &bytes_written,
NULL);
EXPECT_EQ(buffer_size, bytes_written);
}

Expand Down Expand Up @@ -272,8 +273,8 @@ class ChromeCreateFileTest : public PlatformTest {
NULL));
}

EXPECT_FALSE(file_handle == INVALID_HANDLE_VALUE);
::ReadFile(file_handle, read_buffer, buffer_size, &bytes_read, NULL);
EXPECT_TRUE(file_handle.IsValid());
::ReadFile(file_handle.Get(), read_buffer, buffer_size, &bytes_read, NULL);
EXPECT_EQ(buffer_size, bytes_read);
EXPECT_EQ(0, memcmp(kTestData, read_buffer, bytes_read));
}
Expand Down

0 comments on commit 42d5525

Please sign in to comment.