Skip to content

Commit

Permalink
Suppress TSAN races with net::(anonymous namespace)::g_network_change…
Browse files Browse the repository at this point in the history
…_notifier

These races have been around 8+ years so new CLs triggering these TSAN failures
should be ignored.  I've prototyped a fix to avoid the races.
This global variable is set very early in Chrome startup and cleared very late
in Chrome shutdown so reads shouldn't race writes.

Bug: 927330
Change-Id: Ic3ed2446e4cee92dbeda83a0b10ad99a1fbf5d63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566824
Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#650846}
  • Loading branch information
JensenPaul authored and Commit Bot committed Apr 15, 2019
1 parent c5fa639 commit 433cfc1
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions build/sanitizers/tsan_suppressions.cc
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,9 @@ char kTSanDefaultSuppressions[] =
// http://crbug.com/797998
"race:content::SandboxIPCHandler::HandleLocaltime\n"

// http://crbug.com/927330
"race:net::(anonymous namespace)::g_network_change_notifier\n"

// End of suppressions.
; // Please keep this semicolon.

Expand Down

0 comments on commit 433cfc1

Please sign in to comment.