Skip to content

Commit

Permalink
Don't build base with nacl glibc and newlib toolchains
Browse files Browse the repository at this point in the history
It's unnecessary because nothing appears to depend on it,
and it blocks use of C++11 in base.

The IRT build is still enabled because the IRT is the primary user of base_nacl.
The pnacl_newlib build is still enabled because the remoting client uses it.

BUG=360096
R=thakis@chromium.org,mseaborn@chromium.org

Review URL: https://codereview.chromium.org/540093002

Cr-Commit-Position: refs/heads/master@{#293442}
  • Loading branch information
dschuff authored and Commit bot committed Sep 5, 2014
1 parent 23f694a commit 47e06f8
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions base/base_nacl.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
'base_target': 1,
'nacl_untrusted_build': 1,
'nlib_target': 'libbase_nacl.a',
'build_glibc': 1,
'build_newlib': 1,
'build_glibc': 0,
'build_newlib': 0,
'build_irt': 1,
'build_pnacl_newlib': 1,
'sources': [
Expand All @@ -47,7 +47,7 @@
'nacl_untrusted_build': 1,
'nlib_target': 'libbase_i18n_nacl.a',
'build_glibc': 0,
'build_newlib': 1,
'build_newlib': 0,
'build_irt': 0,
'build_pnacl_newlib': 1,
'sources': [
Expand Down

0 comments on commit 47e06f8

Please sign in to comment.