Skip to content

Commit

Permalink
[Code Health] Pass skip_shebang_check=True within PRESUBMIT.py's under
Browse files Browse the repository at this point in the history
build/android, build/skia_gold_common, build/util/lib/common,
tools/style_variable_generator

Bug: 1262347, 1262367, 1262368, 1262369
Change-Id: I5331c9a3232b83020eb8e2729f59c0e63c7f84a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3254724
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Nan Lin <linnan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#936993}
  • Loading branch information
linnan-github authored and Chromium LUCI CQ committed Nov 1, 2021
1 parent 7f8ddfb commit 47eef29
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 4 deletions.
2 changes: 1 addition & 1 deletion build/android/PRESUBMIT.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def J(*dirs):

# Disabled due to http://crbug.com/410936
#output.extend(input_api.canned_checks.RunUnitTestsInDirectory(
#input_api, output_api, J('buildbot', 'tests')))
#input_api, output_api, J('buildbot', 'tests', skip_shebang_check=True)))

pylib_test_env = dict(input_api.environ)
pylib_test_env.update({
Expand Down
3 changes: 2 additions & 1 deletion build/skia_gold_common/PRESUBMIT.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ def CommonChecks(input_api, output_api):
input_api,
output_api,
input_api.PresubmitLocalPath(), [r'^.+_unittest\.py$'],
env=skia_gold_env))
env=skia_gold_env,
skip_shebang_check=True))
output.extend(input_api.canned_checks.RunPylint(input_api, output_api))
return output

Expand Down
6 changes: 5 additions & 1 deletion build/util/lib/common/PRESUBMIT.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,11 @@

def _RunTests(input_api, output_api):
return (input_api.canned_checks.RunUnitTestsInDirectory(
input_api, output_api, '.', files_to_check=[r'.+_test.py$']))
input_api,
output_api,
'.',
files_to_check=[r'.+_test.py$'],
skip_shebang_check=True))


def CheckChangeOnUpload(input_api, output_api):
Expand Down
3 changes: 2 additions & 1 deletion tools/style_variable_generator/PRESUBMIT.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ def _CommonChecks(input_api, output_api):
'.',
files_to_check=TEST_PATTERNS,
env=env,
run_on_python2=False)
run_on_python2=False,
skip_shebang_check=True)
try:
import sys
old_sys_path = sys.path[:]
Expand Down

0 comments on commit 47eef29

Please sign in to comment.