Skip to content

Commit

Permalink
Geolocation: delete GpsLocationProvider and third_party/gpsd/
Browse files Browse the repository at this point in the history
The GpsLocationProvider is not actually used anywhere, and has most likely bit
rotted after years of no maintenance. It is brittle code written for a
specific version (3.1) of gpsd that is now outdated.

The only Chrome version that had this feature enabled (ChromeOS) makes no use
of it as no hardware was ever shipped that used GPS.

TBR=jam,brettw

Review URL: https://codereview.chromium.org/25752005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227104 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
mvanouwerkerk@chromium.org committed Oct 4, 2013
1 parent ee881f4 commit 49e5374
Show file tree
Hide file tree
Showing 12 changed files with 1 addition and 2,571 deletions.
9 changes: 0 additions & 9 deletions build/common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -639,14 +639,6 @@
'linux_use_gold_flags%': 0,
}],

['chromeos==1', {
'linux_use_libgps%': 1,
}, { # chromeos==0
# Do not use libgps on desktop Linux by default,
# see http://crbug.com/103751.
'linux_use_libgps%': 0,
}],

['OS=="android" or OS=="ios"', {
'enable_captive_portal_detection%': 0,
}, {
Expand Down Expand Up @@ -866,7 +858,6 @@
'enable_background%': '<(enable_background)',
'linux_use_gold_binary%': '<(linux_use_gold_binary)',
'linux_use_gold_flags%': '<(linux_use_gold_flags)',
'linux_use_libgps%': '<(linux_use_libgps)',
'use_canvas_skia%': '<(use_canvas_skia)',
'test_isolation_mode%': '<(test_isolation_mode)',
'test_isolation_outdir%': '<(test_isolation_outdir)',
Expand Down
69 changes: 0 additions & 69 deletions build/linux/system.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -118,75 +118,6 @@
},
], # targets
}],
['linux_use_libgps==1', {
'targets': [
{
'target_name': 'libgps',
'type': 'static_library',
'all_dependent_settings': {
'defines': [
'USE_LIBGPS',
],
'include_dirs': [
'<(SHARED_INTERMEDIATE_DIR)',
],
'conditions': [
['linux_link_libgps==1', {
'cflags': [
'<!@(<(pkg-config) --cflags libgps)',
],
'link_settings': {
'ldflags': [
'<!@(<(pkg-config) --libs-only-L --libs-only-other libgps)',
],
'libraries': [
'<!@(<(pkg-config) --libs-only-l libgps)',
],
}
}],
],
},
'include_dirs': [
'../..',
],
'hard_dependency': 1,
'actions': [
{
'variables': {
'output_h': '<(SHARED_INTERMEDIATE_DIR)/library_loaders/libgps.h',
'output_cc': '<(INTERMEDIATE_DIR)/libgps_loader.cc',
'generator': '../../tools/generate_library_loader/generate_library_loader.py',
},
'action_name': 'generate_libgps_loader',
'inputs': [
'<(generator)',
],
'outputs': [
'<(output_h)',
'<(output_cc)',
],
'action': ['python',
'<(generator)',
'--name', 'LibGpsLoader',
'--output-h', '<(output_h)',
'--output-cc', '<(output_cc)',
'--header', '<gps.h>',
'--bundled-header', '"third_party/gpsd/release-3.1/gps.h"',
'--link-directly=<(linux_link_libgps)',
'gps_open',
'gps_close',
'gps_read',
# We don't use gps_shm_read() directly, just to make
# sure that libgps has the shared memory support.
'gps_shm_read',
],
'message': 'Generating libgps library loader.',
'process_outputs_as_sources': 1,
},
],
},
],
}],
], # conditions
'targets': [
{
Expand Down
1 change: 0 additions & 1 deletion content/DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ include_rules = [
# Allow inclusion of third-party code:
"+third_party/angle_dx11",
"+third_party/flac",
"+third_party/gpsd",
"+third_party/libjingle",
"+third_party/mozilla",
"+third_party/npapi/bindings",
Expand Down
Loading

0 comments on commit 49e5374

Please sign in to comment.