Skip to content

Commit

Permalink
Disable */CookieStoreTest/0.TestNonDottedAndTLD tests on iOS 9.
Browse files Browse the repository at this point in the history
The two tests CookieStoreIOS/CookieStoreTest/0.TestNonDottedAndTLD
and RoundTripTestCookieStore/CookieStoreTest/0.TestNonDottedAndTLD
fails with iOS 9, and are thus disabled.

BUG=516603

Review URL: https://codereview.chromium.org/1267843007

Cr-Commit-Position: refs/heads/master@{#342160}
  • Loading branch information
sdefresne authored and Commit bot committed Aug 6, 2015
1 parent 344af25 commit 4cdfe1a
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions net/cookies/cookie_store_unittest.h
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@
#include "testing/gtest/include/gtest/gtest.h"
#include "url/gurl.h"

#if defined(OS_IOS)
#include "base/ios/ios_util.h"
#endif

// This file declares unittest templates that can be used to test common
// behavior of any CookieStore implementation.
// See cookie_monster_unittest.cc for an example of an implementation.
Expand Down Expand Up @@ -483,6 +487,15 @@ TYPED_TEST_P(CookieStoreTest, TestIpAddress) {

// Test host cookies, and setting of cookies on TLD.
TYPED_TEST_P(CookieStoreTest, TestNonDottedAndTLD) {
#if defined(OS_IOS)
// TODO(ellyjones): thoses tests fails with iOS 9, disabled.
// Tracked by http://crbug.com/516603 issue.
if (!TypeParam::supports_non_dotted_domains &&
base::ios::IsRunningOnIOS9OrLater()) {
return;
}
#endif

{
scoped_refptr<CookieStore> cs(this->GetCookieStore());
GURL url("http://com/");
Expand Down

0 comments on commit 4cdfe1a

Please sign in to comment.