Skip to content

Commit

Permalink
Fix mac/component/asan builds
Browse files Browse the repository at this point in the history
Mac asan libraries don't provide operator new/delete unlike on Linux,
so libc++ must provide them.

BUG=933365
R=thakis

Change-Id: I99dfe5aa7979721c0026bdb73845b1a8a012708e
Reviewed-on: https://chromium-review.googlesource.com/c/1479392
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633855}
  • Loading branch information
tanderson-google authored and Commit Bot committed Feb 20, 2019
1 parent 26ffb64 commit 4dce5e8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion buildtools/third_party/libc++/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ target(_libcxx_target_type, "libc++") {
]
}
}
if (is_asan || is_tsan || is_msan) {
if (!is_mac && (is_asan || is_tsan || is_msan)) {
# In {a,t,m}san configurations, operator new and operator delete will be
# provided by the sanitizer runtime library. Since libc++ defines these
# symbols with weak linkage, and the *san runtime uses strong linkage, it
Expand Down

0 comments on commit 4dce5e8

Please sign in to comment.