Skip to content

Commit

Permalink
Fix new -Wconstant-conversion versions after clang r259271
Browse files Browse the repository at this point in the history
http://llvm.org/viewvc/llvm-project?view=revision&revision=259271 made clang's
-Wconversion stricter.  This (together with
https://chromium-review.googlesource.com/#/c/324860/) fixes all new instances
in a chromium/mac build.

No behavior change.

BUG=none

Review URL: https://codereview.chromium.org/1650843002

Cr-Commit-Position: refs/heads/master@{#372689}
  • Loading branch information
nico authored and Commit bot committed Feb 1, 2016
1 parent 4d11b74 commit 4e290e7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion rlz/lib/machine_id_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ TEST(MachineDealCodeTestMachineId, MachineId) {
base::string16 computer_sid(base::UTF8ToUTF16(
"S-1-5-21-2345599882-2448789067-1921365677"));
std::string id;
rlz_lib::testing::GetMachineIdImpl(computer_sid, 2651229008, &id);
rlz_lib::testing::GetMachineIdImpl(computer_sid, -1643738288, &id);
EXPECT_STREQ("A341BA986A7E86840688977FCF20C86E253F00919E068B50F8",
id.c_str());
}
2 changes: 1 addition & 1 deletion tools/battor_agent/battor_connection_impl_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ TEST_F(BattOrConnectionImplTest, ReadMessageInvalidType) {

const char data[] = {
BATTOR_CONTROL_BYTE_START,
UINT8_MAX,
static_cast<char>(UINT8_MAX),
BATTOR_CONTROL_BYTE_ESCAPE,
BATTOR_CONTROL_MESSAGE_TYPE_RESET,
0x04,
Expand Down

0 comments on commit 4e290e7

Please sign in to comment.