Skip to content

Commit

Permalink
Reland "Remove/replace unnecessary logging.h includes in .cc files (i…
Browse files Browse the repository at this point in the history
…pc)"

This is a reland of ba6e417
The revert (crrev.com/c/2165458) was unrelated to this change.

Original change's description:
> Remove/replace unnecessary logging.h includes in .cc files (ipc)
>
> CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved
> to the much smaller headers check.h, check_op.h, and notreached.h,
> respectively.
>
> This CL updates .cc files to use those headers instead when
> possible, with the purpose of saving compile time.
>
> (Split out from https://crrev.com/c/2164525 which also has
> notes on how the change was generated.)
>
> Bug: 1031540
> Change-Id: I9b41171cc43f427005f9a9d78e5cd61341ebeb40
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164512
> Commit-Queue: Tom Sepez <tsepez@chromium.org>
> Auto-Submit: Hans Wennborg <hans@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#762412}

TBR=tsepez

Bug: 1031540
Change-Id: If1f75bd7c8ede51d08b660b3688bf392eceeab7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167437
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762771}
  • Loading branch information
zmodem authored and Commit Bot committed Apr 27, 2020
1 parent 4c48d9e commit 4ed044f
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 6 deletions.
2 changes: 1 addition & 1 deletion ipc/handle_win.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@

#include <utility>

#include "base/logging.h"
#include "base/memory/ref_counted.h"
#include "base/notreached.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/stringprintf.h"
#include "ipc/handle_attachment_win.h"
Expand Down
2 changes: 1 addition & 1 deletion ipc/ipc_mojo_bootstrap.cc
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@

#include "base/bind.h"
#include "base/callback.h"
#include "base/check_op.h"
#include "base/containers/queue.h"
#include "base/logging.h"
#include "base/macros.h"
#include "base/memory/ptr_util.h"
#include "base/no_destructor.h"
Expand Down
3 changes: 2 additions & 1 deletion ipc/ipc_sync_message.cc
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
#include <stdint.h>

#include "base/atomic_sequence_num.h"
#include "base/logging.h"
#include "base/check.h"
#include "base/notreached.h"
#include "build/build_config.h"

namespace {
Expand Down
2 changes: 1 addition & 1 deletion ipc/ipc_sync_message_filter.cc
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
#include "ipc/ipc_sync_message_filter.h"

#include "base/bind.h"
#include "base/check.h"
#include "base/location.h"
#include "base/logging.h"
#include "base/memory/ptr_util.h"
#include "base/memory/ref_counted.h"
#include "base/synchronization/waitable_event.h"
Expand Down
2 changes: 1 addition & 1 deletion ipc/ipc_sync_message_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
// works. This ensures that the macros and templates were defined correctly.
// Doesn't test the IPC channel mechanism.

#include "base/logging.h"
#include "base/check_op.h"
#include "ipc/ipc_message.h"
#include "ipc/ipc_message_utils.h"
#include "testing/gtest/include/gtest/gtest.h"
Expand Down
2 changes: 1 addition & 1 deletion ipc/mach_port_mac.cc
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@

#include "ipc/mach_port_mac.h"

#include "base/logging.h"
#include "base/memory/ref_counted.h"
#include "base/notreached.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/stringprintf.h"
#include "ipc/mach_port_attachment_mac.h"
Expand Down

0 comments on commit 4ed044f

Please sign in to comment.