Add prefix to empty param tests.

googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=jam@chromium.org Bug: 1023677 Change-Id: I261ccc105df9968d29dbe90d62aeb670bb403b45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926913 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#717941}
Denger-Network · Nov 22, 2019 · 500c3e4 · 500c3e4
1 parent 2532333
commit 500c3e4
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/mojo/core/multiprocess_message_pipe_unittest.cc b/mojo/core/multiprocess_message_pipe_unittest.cc
@@ -1369,7 +1369,7 @@ DEFINE_TEST_CLIENT_TEST_WITH_PIPE(BadMessageClient,
 }
 
 INSTANTIATE_TEST_SUITE_P(
-    ,
+    All,
     MultiprocessMessagePipeTestWithPeerSupport,
     testing::Values(test::MojoTestBase::LaunchType::CHILD,
                     test::MojoTestBase::LaunchType::PEER,

diff --git a/mojo/public/cpp/bindings/tests/receiver_unittest.cc b/mojo/public/cpp/bindings/tests/receiver_unittest.cc
@@ -746,7 +746,7 @@ INSTANTIATE_MOJO_BINDINGS_TEST_SUITE_P(StrongBindingTest);
 
 // These tests only make sense for serialized messages.
 INSTANTIATE_TEST_SUITE_P(
-    ,
+    All,
     ReceiverSerializationTest,
     testing::Values(mojo::BindingsTestSerializationMode::kSerializeBeforeSend));
 

diff --git a/mojo/public/cpp/platform/tests/platform_handle_unittest.cc b/mojo/public/cpp/platform/tests/platform_handle_unittest.cc
@@ -244,7 +244,7 @@ TEST_P(PlatformHandleTest, CStructConversion) {
   EXPECT_EQ(kTestData, GetObjectContents(handle));
 }
 
-INSTANTIATE_TEST_SUITE_P(,
+INSTANTIATE_TEST_SUITE_P(All,
                          PlatformHandleTest,
 #if defined(OS_WIN)
                          testing::Values(HandleType::kHandle)

diff --git a/mojo/public/cpp/system/tests/invitation_unittest.cc b/mojo/public/cpp/system/tests/invitation_unittest.cc
@@ -323,7 +323,7 @@ DEFINE_TEST_CLIENT(CppProcessErrorsClient) {
   EXPECT_EQ(kDisconnectMessage, ReadMessage(pipe));
 }
 
-INSTANTIATE_TEST_SUITE_P(,
+INSTANTIATE_TEST_SUITE_P(All,
                          InvitationCppTest,
                          testing::Values(TransportType::kChannel
 #if !defined(OS_FUCHSIA)