Skip to content

Commit

Permalink
Remove 'settings' type from gyp files
Browse files Browse the repository at this point in the history
It is not actually supported by gyp; the fact that it works is a bug
that I am working on fixing.

BUG=96629

Review URL: http://codereview.chromium.org/7889051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102306 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
evan@chromium.org committed Sep 22, 2011
1 parent 6f02d70 commit 50d8c0e
Show file tree
Hide file tree
Showing 9 changed files with 27 additions and 27 deletions.
38 changes: 19 additions & 19 deletions build/linux/system.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
'targets': [
{
'target_name': 'gtk',
'type': 'settings',
'type': 'none',
'toolsets': ['host', 'target'],
'conditions': [
['_toolset=="target"', {
Expand Down Expand Up @@ -71,7 +71,7 @@
},
{
'target_name': 'gtkprint',
'type': 'settings',
'type': 'none',
'conditions': [
['_toolset=="target"', {
'direct_dependent_settings': {
Expand All @@ -92,7 +92,7 @@
},
{
'target_name': 'ssl',
'type': 'settings',
'type': 'none',
'conditions': [
['_toolset=="target"', {
'conditions': [
Expand Down Expand Up @@ -149,7 +149,7 @@
},
{
'target_name': 'freetype2',
'type': 'settings',
'type': 'none',
'conditions': [
['_toolset=="target"', {
'direct_dependent_settings': {
Expand All @@ -170,7 +170,7 @@
},
{
'target_name': 'fontconfig',
'type': 'settings',
'type': 'none',
'conditions': [
['_toolset=="target"', {
'direct_dependent_settings': {
Expand All @@ -191,7 +191,7 @@
},
{
'target_name': 'gdk',
'type': 'settings',
'type': 'none',
'conditions': [
['_toolset=="target"', {
'direct_dependent_settings': {
Expand All @@ -212,7 +212,7 @@
},
{
'target_name': 'gconf',
'type': 'settings',
'type': 'none',
'conditions': [
['use_gconf==1 and _toolset=="target"', {
'direct_dependent_settings': {
Expand All @@ -236,7 +236,7 @@
},
{
'target_name': 'gio',
'type': 'settings',
'type': 'none',
'conditions': [
['use_gio==1 and _toolset=="target"', {
'direct_dependent_settings': {
Expand Down Expand Up @@ -308,7 +308,7 @@
},
{
'target_name': 'xext',
'type': 'settings',
'type': 'none',
'conditions': [
['_toolset=="target"', {
'direct_dependent_settings': {
Expand All @@ -329,7 +329,7 @@
},
{
'target_name': 'libgcrypt',
'type': 'settings',
'type': 'none',
'conditions': [
['_toolset=="target" and use_cups==1', {
'direct_dependent_settings': {
Expand All @@ -347,7 +347,7 @@
},
{
'target_name': 'selinux',
'type': 'settings',
'type': 'none',
'conditions': [
['_toolset=="target"', {
'link_settings': {
Expand All @@ -360,7 +360,7 @@
},
{
'target_name': 'gnome_keyring',
'type': 'settings',
'type': 'none',
'conditions': [
['use_gnome_keyring==1', {
'direct_dependent_settings': {
Expand Down Expand Up @@ -403,7 +403,7 @@
# link directly in this version of the target to allow this.
# *** Do not use this target in the main binary! ***
'target_name': 'gnome_keyring_direct',
'type': 'settings',
'type': 'none',
'conditions': [
['use_gnome_keyring==1', {
'direct_dependent_settings': {
Expand Down Expand Up @@ -432,7 +432,7 @@
},
{
'target_name': 'dbus',
'type': 'settings',
'type': 'none',
'direct_dependent_settings': {
'cflags': [
'<!@(<(pkg-config) --cflags dbus-1)',
Expand All @@ -450,7 +450,7 @@
{
# TODO(satorux): Remove this once dbus-glib clients are gone.
'target_name': 'dbus-glib',
'type': 'settings',
'type': 'none',
'direct_dependent_settings': {
'cflags': [
'<!@(<(pkg-config) --cflags dbus-glib-1)',
Expand All @@ -467,7 +467,7 @@
},
{
'target_name': 'glib',
'type': 'settings',
'type': 'none',
'toolsets': ['host', 'target'],
'conditions': [
['_toolset=="target"', {
Expand Down Expand Up @@ -544,7 +544,7 @@
},
{
'target_name': 'libresolv',
'type': 'settings',
'type': 'none',
'link_settings': {
'libraries': [
'-lresolv',
Expand All @@ -553,7 +553,7 @@
},
{
'target_name': 'ibus',
'type': 'settings',
'type': 'none',
'conditions': [
['use_ibus==1', {
'variables': {
Expand All @@ -578,7 +578,7 @@
},
{
'target_name': 'wayland',
'type': 'settings',
'type': 'none',
'conditions': [
['use_wayland == 1', {
'cflags': [
Expand Down
2 changes: 1 addition & 1 deletion sandbox/sandbox.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@
'targets': [
{
'target_name': 'sandbox',
'type': 'settings',
'type': 'none',
'conditions': [
# Only compile in the seccomp code for the flag combination
# where we support it.
Expand Down
2 changes: 1 addition & 1 deletion third_party/bzip2/bzip2.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
'targets': [
{
'target_name': 'bzip2',
'type': 'settings',
'type': 'none',

'direct_dependent_settings': {
'defines': [
Expand Down
2 changes: 1 addition & 1 deletion third_party/expat/expat.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
'targets': [
{
'target_name': 'expat',
'type': 'settings',
'type': 'none',
'link_settings': {
'libraries': [
'-lexpat',
Expand Down
2 changes: 1 addition & 1 deletion third_party/libjpeg/libjpeg.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
'targets': [
{
'target_name': 'libjpeg',
'type': 'settings',
'type': 'none',
'direct_dependent_settings': {
'defines': [
'USE_SYSTEM_LIBJPEG',
Expand Down
2 changes: 1 addition & 1 deletion third_party/libpng/libpng.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
'targets': [
{
'target_name': 'libpng',
'type': 'settings',
'type': 'none',
'dependencies': [
'../zlib/zlib.gyp:zlib',
],
Expand Down
2 changes: 1 addition & 1 deletion third_party/libwebp/libwebp.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
'targets': [
{
'target_name': 'libwebp',
'type': 'settings',
'type': 'none',
'direct_dependent_settings': {
'defines': [
'ENABLE_WEBP',
Expand Down
2 changes: 1 addition & 1 deletion third_party/libxml/libxml.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
'target_name': 'libxml',
'conditions': [
['os_posix == 1 and OS != "mac" and use_system_libxml', {
'type': 'settings',
'type': 'none',
'direct_dependent_settings': {
'cflags': [
'<!@(pkg-config --cflags libxml-2.0)',
Expand Down
2 changes: 1 addition & 1 deletion third_party/libxslt/libxslt.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
'target_name': 'libxslt',
'conditions': [
['os_posix == 1 and OS != "mac" and use_system_libxml', {
'type': 'settings',
'type': 'none',
'direct_dependent_settings': {
'cflags': [
'<!@(pkg-config --cflags libxslt)',
Expand Down

0 comments on commit 50d8c0e

Please sign in to comment.