Skip to content

Commit

Permalink
Roll androidx from 5wEAJbMDQ... to Hc8o8AHtY... (Reland)
Browse files Browse the repository at this point in the history
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/androidx-chromium
Please CC mheikal@google.com,clank-library-failures@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

This reverts commit 6dc98cc.

Reason for revert: Fixed cronet issue

Modification: Fix expectations and weblayer + cronet test
Tbr: mheikal@google.com,clank-library-failures@google.com
Bug: 1205141,1215898
Change-Id: I3277d1678a040ef5ae937cf7d1e0edd802c0e116
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2935293
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Auto-Submit: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#888998}
  • Loading branch information
m0hamed authored and Chromium LUCI CQ committed Jun 3, 2021
1 parent a9d00cc commit 51ae43a
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 11 deletions.
2 changes: 1 addition & 1 deletion DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -730,7 +730,7 @@ deps = {
'packages': [
{
'package': 'chromium/third_party/androidx',
'version': '5wEAJbMDQJnCxXbN6hMn66IR4akg1G25HQtc_8_7Vz0C',
'version': '8d-gGcc4KVhOnn2B-Od7eR421Q-sNZQ0U7dMrNz_VX4C',
},
],
'condition': 'checkout_android',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -646,16 +646,6 @@
<init>();
}

# File: obj/third_party/androidx/androidx_startup_startup_runtime_java/proguard.txt
# This Proguard rule ensures that ComponentInitializers are are neither shrunk nor obfuscated.
# This is because they are discovered and instantiated during application initialization.
-keep class * extends androidx.startup.Initializer {
# Keep the public no-argument constructor while allowing other methods to be optimized.
<init>();
}

-assumenosideeffects class androidx.startup.StartupLogger

# File: obj/third_party/androidx/androidx_transition_transition_java/proguard.txt
# Copyright (C) 2017 The Android Open Source Project
#
Expand Down
8 changes: 8 additions & 0 deletions components/cronet/android/sample/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
-->

<manifest xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
package="org.chromium.cronet_sample_apk">

<uses-permission android:name="android.permission.INTERNET"/>
Expand All @@ -23,5 +24,12 @@
<category android:name="android.intent.category.LAUNCHER"/>
</intent-filter>
</activity>
<!-- Disables at startup init of Emoji2. See http://crbug.com/1205141 -->
<provider
android:authorities="org.chromium.cronet_sample_apk.androidx-startup"
android:name="androidx.startup.InitializationProvider"
android:exported="false"
tools:node="remove">
</provider>
</application>
</manifest>
9 changes: 9 additions & 0 deletions weblayer/shell/android/shell_apk/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
-->

<manifest xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
package="org.chromium.weblayer.shell">

<application android:label="WebLayer shell"
Expand Down Expand Up @@ -63,6 +64,14 @@
<meta-data
android:name="org.chromium.weblayer.ENABLE_LOGGING_OF_JS_CONSOLE_MESSAGES" android:value="true"/>

<!-- Disables at startup init of Emoji2. See http://crbug.com/1205141 -->
<provider
android:authorities="org.chromium.weblayer.shell.androidx-startup"
android:name="androidx.startup.InitializationProvider"
android:exported="false"
tools:node="remove">
</provider>

{% if weblayer_package is defined %}
<meta-data android:name="org.chromium.weblayer.WebLayerPackage"
android:value="{{ weblayer_package }}"/>
Expand Down

0 comments on commit 51ae43a

Please sign in to comment.