Skip to content

Commit

Permalink
[Chromecast] Replace test ASSERT to fix compilation errors.
Browse files Browse the repository at this point in the history
BUG=internal b/19210655

Review URL: https://codereview.chromium.org/1336763008

Cr-Commit-Position: refs/heads/master@{#348748}
  • Loading branch information
baileyforrest authored and Commit bot committed Sep 14, 2015
1 parent 2933c07 commit 51c8f6f
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ void produce_dumps(SynchronizedMinidumpManagerSimple& producer, int num_dumps) {
void consume_dumps(FakeSynchronizedMinidumpUploader& consumer, int num_dumps) {
for (int i = 0; i < num_dumps; ++i) {
ASSERT_EQ(0, consumer.DoWorkLocked());
ASSERT_EQ(true, consumer.can_upload_return_val());
ASSERT_TRUE(consumer.can_upload_return_val());
}
}

Expand Down Expand Up @@ -464,7 +464,7 @@ TEST_F(SynchronizedMinidumpManagerTest, Upload_FailsWhenTooManyRecentDumps) {

// Should fail with too many dumps
ASSERT_EQ(0, uploader.DoWorkLocked());
ASSERT_EQ(false, uploader.can_upload_return_val());
ASSERT_FALSE(uploader.can_upload_return_val());
}

TEST_F(SynchronizedMinidumpManagerTest, UploadSucceedsAfterRateLimitPeriodEnd) {
Expand All @@ -487,15 +487,15 @@ TEST_F(SynchronizedMinidumpManagerTest, UploadSucceedsAfterRateLimitPeriodEnd) {

// Should fail with too many dumps
ASSERT_EQ(0, uploader.DoWorkLocked());
ASSERT_EQ(false, uploader.can_upload_return_val());
ASSERT_FALSE(uploader.can_upload_return_val());

int64 period = SynchronizedMinidumpManager::kRatelimitPeriodSeconds;

// Half period shouldn't trigger reset
produce_dumps(producer, 1);
SetRatelimitPeriodStart(metadata_.value(), now - period / 2);
ASSERT_EQ(0, uploader.DoWorkLocked());
ASSERT_EQ(false, uploader.can_upload_return_val());
ASSERT_FALSE(uploader.can_upload_return_val());

// Set period starting time to trigger a reset
SetRatelimitPeriodStart(metadata_.value(), now - period);
Expand Down

0 comments on commit 51c8f6f

Please sign in to comment.