Skip to content

Commit

Permalink
weblayer: Disable ExternalNavigationTests subtests for M83 skew testing
Browse files Browse the repository at this point in the history
Disable the following for M83 client skew tests
org.chromium.weblayer.test.ExternalNavigationTest#testExternalIntentWithNoRedirectBlocked

Disable the following for M83 implementtion skew tests
org.chromium.weblayer.test.ExternalNavigationTest#testExternalIntentWithNoRedirectLaunched

TBR=jam@chromium.org

Bug: 1096570
Change-Id: I23fa50f5ac46da88315468e904893ad3fc99329f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274465
Commit-Queue: Rakib Hasan <rmhasan@google.com>
Reviewed-by: Erik Staab <estaab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#784054}
  • Loading branch information
Rakib M. Hasan authored and Commit Bot committed Jun 30, 2020
1 parent fd10b18 commit 53115e1
Showing 1 changed file with 16 additions and 13 deletions.
29 changes: 16 additions & 13 deletions weblayer/browser/android/javatests/skew/expectations.txt
Original file line number Diff line number Diff line change
Expand Up @@ -22,25 +22,28 @@
[ impl_lte_83 ] org.chromium.weblayer.test.TabTest#testBeforeUnloadNoHandler [ Skip ]
[ impl_lte_83 ] org.chromium.weblayer.test.TabTest#testBeforeUnloadNoInteraction [ Skip ]

# Replace was removed in https://crrev.com/c/2150968, see https://crbug.com/1070851.
[ impl_lte_83 ] org.chromium.weblayer.test.NavigationTest#testReplace [ Skip ]
# Replace was removed in https://crrev.com/c/2150968.
crbug.com/1070851 [ impl_lte_83 ] org.chromium.weblayer.test.NavigationTest#testReplace [ Skip ]

# Fixed in https://crrev.com/c/2180022, see https://crbug.com/1077243.
[ impl_lte_83 ] org.chromium.weblayer.test.FullscreenCallbackTest#testExitFullscreenWhenTabDestroyed [ Skip ]
# Fixed in https://crrev.com/c/2180022.
crbug.com/1077243 [ impl_lte_83 ] org.chromium.weblayer.test.FullscreenCallbackTest#testExitFullscreenWhenTabDestroyed [ Skip ]

# https://crbug.com/1079491.
[ impl_lte_83 ] org.chromium.weblayer.test.NavigationTest#testSetUserAgentString [ Skip ]
crbug.com/1079491 [ impl_lte_83 ] org.chromium.weblayer.test.NavigationTest#testSetUserAgentString [ Skip ]

crbug.com/1096570 [ impl_lte_83 ] org.chromium.weblayer.test.ExternalNavigationTest#testExternalIntentWithNoRedirectLaunched [ Skip ]

# -------------------------------------
# Tests against older WebLayer clients.
# -------------------------------------

# Intentionally changed in M84, https://crrev.com/c/2130790. See https://crbug.com/1078973.
[ client_lte_83 ] org.chromium.weblayer.test.ExternalNavigationTest#testExternalIntentLaunchedViaOnLoad [ Skip ]
[ client_lte_83 ] org.chromium.weblayer.test.ExternalNavigationTest#testNonHandledExternalIntentWithFallbackUrlThatLaunchesIntentAfterRedirectLaunchesFallbackIntent [ Skip ]
# Intentionally changed in M84, https://crrev.com/c/2130790.
crbug.com/1078973 [ client_lte_83 ] org.chromium.weblayer.test.ExternalNavigationTest#testExternalIntentLaunchedViaOnLoad [ Skip ]
crbug.com/1078973 [ client_lte_83 ] org.chromium.weblayer.test.ExternalNavigationTest#testNonHandledExternalIntentWithFallbackUrlThatLaunchesIntentAfterRedirectLaunchesFallbackIntent [ Skip ]

# Replace was removed in https://crrev.com/c/2150968.
crbug.com/1070851 [ client_lte_83 ] org.chromium.weblayer.test.NavigationTest#testReplace [ Skip ]

# Replace was removed in https://crrev.com/c/2150968, see https://crbug.com/1070851.
[ client_lte_83 ] org.chromium.weblayer.test.NavigationTest#testReplace [ Skip ]
# Test was made private.
crbug.com/1087451 [ client_lte_84 ] org.chromium.weblayer.test.TopControlsTest#testBasic [ Skip ]

# Test was made private, https://crbug.com/1087451.
[ client_lte_84 ] org.chromium.weblayer.test.TopControlsTest#testBasic [ Skip ]
crbug.com/1096570 [ client_lte_83 ] org.chromium.weblayer.test.ExternalNavigationTest#testExternalIntentWithNoRedirectBlocked [ Skip ]

0 comments on commit 53115e1

Please sign in to comment.