Skip to content

Commit

Permalink
Mark http/tests/devtools/appcache/* as skipped
Browse files Browse the repository at this point in the history
These tests fail without appcache, but they also fail in such a way that
they print a stack trace.  This stack trace is different in debug and
release modes, and it seems extremely brittle to bake a stack trace into
an expectation.  Just skip these tests until appcache is removed as they
are currently not testing very much at all.

Bug: 1093620, 582750
Change-Id: I3803889c2f8d0f0d92b101acc2cdf77bd104f8b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241457
Commit-Queue: enne <enne@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Auto-Submit: enne <enne@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777389}
  • Loading branch information
quisquous authored and Commit Bot committed Jun 11, 2020
1 parent 78b6d35 commit 5477cd5
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
3 changes: 3 additions & 0 deletions third_party/blink/web_tests/NeverFixTests
Original file line number Diff line number Diff line change
Expand Up @@ -2076,6 +2076,9 @@ crbug.com/582750 http/tests/loading/appcache-delay/appcache-loads-subresource.ht
crbug.com/582750 http/tests/security/cors-rfc1918/addressspace-document-appcache.https.html [ Skip ]
crbug.com/582750 http/tests/security/cors-rfc1918/addressspace-document-csp-appcache.https.html [ Skip ]

# These appcache tests fail differently in release and debug, so skip them.
crbug.com/582750 http/tests/devtools/appcache/* [ Skip ]

# Remove these from virtual tests when Network Error Logging is turned on by default
crbug.com/748549 external/wpt/network-error-logging/* [ Skip ]
virtual/network-error-logging/external/wpt/network-error-logging/* [ Pass ]
Expand Down
1 change: 0 additions & 1 deletion third_party/blink/web_tests/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -6727,6 +6727,5 @@ crbug.com/1093003 [ Mac ] external/wpt/html/rendering/replaced-elements/embedded

# Sheriff 2020-06-10
crbug.com/1093429 [ Mac ] external/wpt/webrtc/RTCPeerConnection-getStats.https.html [ Failure ]
crbug.com/1093620 [ Debug ] http/tests/devtools/appcache/* [ Pass Failure ]
crbug.com/1093709 [ Mac ] external/wpt/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.resize.html [ Pass Failure ]
crbug.com/1093709 [ Linux ] external/wpt/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.resize.html [ Pass Failure ]

0 comments on commit 5477cd5

Please sign in to comment.