Skip to content

Commit

Permalink
Remove Cloud Print virtual_driver code.
Browse files Browse the repository at this point in the history
The virtual Cloud Print printer driver for Windows is useless without a
server to send jobs to.

Bug: 1162164
Change-Id: Iea4dbce03aa2df8310a699769b3cbf9d44729326
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3490763
Reviewed-by: Alan Screen <awscreen@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Auto-Submit: Lei Zhang <thestig@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/main@{#984987}
  • Loading branch information
leizleiz authored and Chromium LUCI CQ committed Mar 24, 2022
1 parent 1459c17 commit 5561c29
Show file tree
Hide file tree
Showing 99 changed files with 3 additions and 4,114 deletions.
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,6 @@ vs-chromium-project.txt
/chromeos/profiles/*.afdo.prof
/cipd_cache/
/clank
/cloud_print/cloud_print_version_resources.xml
/components/chrome_settings_proto_generated_compile.xml
/components/cloud_policy_proto_generated_compile.xml
/components/gcm_driver.xml
Expand Down
3 changes: 0 additions & 3 deletions BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -655,7 +655,6 @@ group("gn_all") {
"//chrome/installer/setup:setup_unittests",
"//chrome/notification_helper:notification_helper_unittests",
"//chrome/test:delayloads_unittests",
"//cloud_print:cloud_print_unittests",
"//components/wifi:wifi_test",
"//components/zucchini",
"//net:quic_client",
Expand Down Expand Up @@ -925,8 +924,6 @@ if (is_win) {
"//chrome/installer/gcapi",
"//chrome/installer/mini_installer",
"//chrome/updater/win:updater_zip",
"//cloud_print",
"//cloud_print/virtual_driver/win/port_monitor:copy_gcp_portmon_binaries",
"//components/policy:pack_policy_templates",
"//components/zucchini",
"//courgette",
Expand Down
1 change: 0 additions & 1 deletion PRESUBMIT.py
Original file line number Diff line number Diff line change
Expand Up @@ -2298,7 +2298,6 @@ def CheckSpamLogging(input_api, output_api):
r"dll_hash_main\.cc$",
r"^chrome[\\/]installer[\\/]setup[\\/].*",
r"^chromecast[\\/]",
r"^cloud_print[\\/]",
r"^components[\\/]browser_watcher[\\/]"
r"dump_stability_report_main_win.cc$",
r"^components[\\/]media_control[\\/]renderer[\\/]"
Expand Down
7 changes: 0 additions & 7 deletions chrome/browser/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -6422,13 +6422,6 @@ static_library("browser") {
"printing/pwg_raster_converter.cc",
"printing/pwg_raster_converter.h",
]

if (is_win) {
sources += [
"printing/print_dialog_cloud_win.cc",
"printing/print_dialog_cloud_win.h",
]
}
} else {
# Partial - only printing support.
sources += [
Expand Down
2 changes: 1 addition & 1 deletion chrome/browser/local_discovery/OWNERS
Original file line number Diff line number Diff line change
@@ -1 +1 @@
file://cloud_print/OWNERS
thestig@chromium.org
164 changes: 0 additions & 164 deletions chrome/browser/printing/print_dialog_cloud_win.cc

This file was deleted.

22 changes: 0 additions & 22 deletions chrome/browser/printing/print_dialog_cloud_win.h

This file was deleted.

13 changes: 0 additions & 13 deletions chrome/browser/ui/startup/startup_browser_creator.cc
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,6 @@
#include "chrome/browser/ui/webui/settings/reset_settings_handler.h"
#include "chrome/browser/web_applications/web_app_provider.h"
#include "chrome/credential_provider/common/gcp_strings.h"
#if BUILDFLAG(ENABLE_PRINT_PREVIEW)
#include "chrome/browser/printing/print_dialog_cloud_win.h"
#endif // BUILDFLAG(ENABLE_PRINT_PREVIEW)
#endif // BUILDFLAG(IS_WIN)

#if BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_MAC) || BUILDFLAG(IS_WIN)
Expand Down Expand Up @@ -860,16 +857,6 @@ bool StartupBrowserCreator::ProcessCmdLineImpl(
Profile* privacy_safe_profile =
GetPrivateProfileIfRequested(command_line, profile_info);

#if BUILDFLAG(IS_WIN) && BUILDFLAG(ENABLE_PRINT_PREVIEW)
// If we are just displaying a print dialog we shouldn't open browser
// windows.
if (command_line.HasSwitch(switches::kCloudPrintFile) && can_use_profile &&
print_dialog_cloud::CreatePrintDialogFromCommandLine(privacy_safe_profile,
command_line)) {
silent_launch = true;
}
#endif // BUILDFLAG(IS_WIN) && BUILDFLAG(ENABLE_PRINT_PREVIEW)

if (command_line.HasSwitch(switches::kValidateCrx)) {
if (process_startup == chrome::startup::IsProcessStartup::kNo) {
LOG(ERROR) << "chrome is already running; you must close all running "
Expand Down
16 changes: 0 additions & 16 deletions chrome/common/chrome_switches.cc
Original file line number Diff line number Diff line change
Expand Up @@ -115,22 +115,6 @@ const char kCheckForUpdateIntervalSec[] = "check-for-update-interval";
// Comma-separated list of SSL cipher suites to disable.
const char kCipherSuiteBlacklist[] = "cipher-suite-blacklist";

// Tells chrome to display the cloud print dialog and upload the specified file
// for printing.
const char kCloudPrintFile[] = "cloud-print-file";

// Specifies the mime type to be used when uploading data from the file
// referenced by cloud-print-file. Defaults to "application/pdf" if
// unspecified.
const char kCloudPrintFileType[] = "cloud-print-file-type";

// Used with kCloudPrintFile to specify a title for the resulting print job.
const char kCloudPrintJobTitle[] = "cloud-print-job-title";

// Used with kCloudPrintFile to specify a JSON print ticket for the resulting
// print job. Defaults to null if unspecified.
const char kCloudPrintPrintTicket[] = "cloud-print-print-ticket";

// Comma-separated list of BrowserThreads that cause browser process to crash if
// the given browser thread is not responsive. UI/IO are the BrowserThreads that
// are supported.
Expand Down
4 changes: 0 additions & 4 deletions chrome/common/chrome_switches.h
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,6 @@ extern const char kAutoSelectDesktopCaptureSource[];
extern const char kAutoSelectTabCaptureSourceByTitle[];
extern const char kCheckForUpdateIntervalSec[];
extern const char kCipherSuiteBlacklist[];
extern const char kCloudPrintFile[];
extern const char kCloudPrintFileType[];
extern const char kCloudPrintJobTitle[];
extern const char kCloudPrintPrintTicket[];
extern const char kCrashOnHangThreads[];
extern const char kCreateBrowserOnStartupForTests[];
extern const char kCustomDevtoolsFrontend[];
Expand Down
40 changes: 0 additions & 40 deletions chrome/tools/build/win/FILES.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -558,46 +558,6 @@ FILES = [
'archive': 'gcp_installer.exe',
'filegroup': ['symsrc'],
},
# Cloud Print files:
{
'filename': 'gcp_portmon.dll',
'buildtype': ['official'],
'archive': 'cloud_print.zip',
'filegroup': ['symsrc'],
},
{
'filename': 'gcp_portmon.dll.pdb',
'buildtype': ['official'],
'archive': 'cloud_print.zip',
'optional': ['official'],
},
{
'filename': 'gcp_portmon64.dll',
'buildtype': ['official'],
'archive': 'cloud_print.zip',
'filegroup': ['symsrc'],
},
{
'filename': 'gcp_driver.inf',
'buildtype': ['official'],
'archive': 'cloud_print.zip',
},
{
'filename': 'gcp_driver.gpd',
'buildtype': ['official'],
'archive': 'cloud_print.zip',
},
{
'filename': 'virtual_driver_setup.exe',
'buildtype': ['official'],
'archive': 'cloud_print.zip',
'filegroup': ['symsrc'],
},
{
'filename': 'virtual_driver_setup.exe.pdb',
'buildtype': ['official'],
'archive': 'cloud_print.zip',
},
# Test binaries for external QA:
{
'filename': 'interactive_ui_tests.exe',
Expand Down
2 changes: 1 addition & 1 deletion chrome/tools/service_discovery_sniffer/OWNERS
Original file line number Diff line number Diff line change
@@ -1 +1 @@
file://cloud_print/OWNERS
thestig@chromium.org
3 changes: 0 additions & 3 deletions cloud_print/BRANDING

This file was deleted.

39 changes: 0 additions & 39 deletions cloud_print/BUILD.gn

This file was deleted.

3 changes: 0 additions & 3 deletions cloud_print/COMMON_METADATA

This file was deleted.

Loading

0 comments on commit 5561c29

Please sign in to comment.