Skip to content

Commit

Permalink
Remove most remaining unused "base/macros.h"
Browse files Browse the repository at this point in the history 
Removes `#include "base/macros.h"` from remaining .cc, .h and .mm files
that do not contain `ignore_result(` and do not trigger pre-commit or
pre-upload errors.

Bug: 1010217
No-Try: true
Change-Id: I4cc5207b3deafa7901764d2e633bbb1ad43cfb73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3276692
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Owners-Override: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#941054}
  • Loading branch information
@pbos
pbos authored and Chromium LUCI CQ committed Nov 12, 2021
1 parent 413fd16 commit 5666ff4
Show file tree
Hide file tree
Showing 4,330 changed files with 1 addition and 4,478 deletions.
The diff you're trying to view is too large. We only load the first 3000 changed files.
1 change: 0 additions & 1 deletion android_webview/browser/aw_autofill_client.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@

#include "base/android/jni_weak_ref.h"
#include "base/compiler_specific.h"
#include "base/macros.h"
#include "components/autofill/core/browser/autofill_client.h"
#include "components/autofill/core/browser/payments/legal_message_line.h"
#include "content/public/browser/web_contents_user_data.h"
Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/aw_browser_context.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
#include "android_webview/browser/network_service/aw_proxy_config_monitor.h"
#include "base/compiler_specific.h"
#include "base/files/file_path.h"
#include "base/macros.h"
#include "base/memory/ref_counted.h"
#include "components/keyed_service/core/simple_factory_key.h"
#include "components/prefs/pref_registry_simple.h"
Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/aw_browser_main_parts.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

#include "android_webview/browser/aw_browser_process.h"
#include "base/compiler_specific.h"
#include "base/macros.h"
#include "base/task/single_thread_task_executor.h"
#include "content/public/browser/browser_main_parts.h"

Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/aw_browser_policy_connector.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
#ifndef ANDROID_WEBVIEW_BROWSER_AW_BROWSER_POLICY_CONNECTOR_H_
#define ANDROID_WEBVIEW_BROWSER_AW_BROWSER_POLICY_CONNECTOR_H_

#include "base/macros.h"
#include "components/policy/core/browser/browser_policy_connector_base.h"

namespace android_webview {
Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/aw_browser_terminator.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
#ifndef ANDROID_WEBVIEW_BROWSER_AW_BROWSER_TERMINATOR_H_
#define ANDROID_WEBVIEW_BROWSER_AW_BROWSER_TERMINATOR_H_

#include "base/macros.h"
#include "components/crash/content/browser/child_exit_observer_android.h"

namespace android_webview {
Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/aw_content_browser_client.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
#include <string>
#include <vector>

#include "base/macros.h"
#include "base/memory/ref_counted.h"
#include "content/public/browser/content_browser_client.h"
#include "content/public/browser/web_contents.h"
Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/aw_contents.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@
#include "base/i18n/rtl.h"
#include "base/json/json_writer.h"
#include "base/location.h"
#include "base/macros.h"
#include "base/memory/memory_pressure_listener.h"
#include "base/no_destructor.h"
#include "base/pickle.h"
Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/aw_contents.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
#include "base/android/jni_weak_ref.h"
#include "base/android/scoped_java_ref.h"
#include "base/callback_forward.h"
#include "base/macros.h"
#include "components/js_injection/browser/js_communication_host.h"
#include "content/public/browser/web_contents_observer.h"

Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/aw_contents_client_bridge.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
#include "base/android/jni_android.h"
#include "base/android/jni_array.h"
#include "base/android/jni_string.h"
#include "base/macros.h"
#include "base/memory/ref_counted.h"
#include "base/task/current_thread.h"
#include "content/public/browser/browser_thread.h"
Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/aw_contents_client_bridge_unittest.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
#include "base/android/jni_array.h"
#include "base/android/scoped_java_ref.h"
#include "base/bind.h"
#include "base/macros.h"
#include "base/memory/ptr_util.h"
#include "base/run_loop.h"
#include "content/public/browser/client_certificate_delegate.h"
Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/aw_contents_io_thread_client.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
#include "base/android/scoped_java_ref.h"
#include "base/callback_forward.h"
#include "base/compiler_specific.h"
#include "base/macros.h"
#include "base/task/post_task.h"
#include "base/task/thread_pool.h"
#include "content/public/browser/global_routing_id.h"
Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/aw_cookie_access_policy.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
#ifndef ANDROID_WEBVIEW_BROWSER_AW_COOKIE_ACCESS_POLICY_H_
#define ANDROID_WEBVIEW_BROWSER_AW_COOKIE_ACCESS_POLICY_H_

#include "base/macros.h"
#include "base/no_destructor.h"
#include "base/synchronization/lock.h"

Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/aw_devtools_manager_delegate.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
#include <memory>
#include <vector>

#include "base/macros.h"
#include "content/public/browser/devtools_manager_delegate.h"

namespace android_webview {
Expand Down
2 changes: 0 additions & 2 deletions android_webview/browser/aw_devtools_server.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@
#ifndef ANDROID_WEBVIEW_BROWSER_AW_DEVTOOLS_SERVER_H_
#define ANDROID_WEBVIEW_BROWSER_AW_DEVTOOLS_SERVER_H_

#include "base/macros.h"

namespace android_webview {

// This class controls WebView-specific Developer Tools remote debugging server.
Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/aw_download_manager_delegate.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@

#include <string>

#include "base/macros.h"
#include "base/supports_user_data.h"
#include "content/public/browser/download_manager_delegate.h"

Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/aw_field_trials.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
#ifndef ANDROID_WEBVIEW_BROWSER_AW_FIELD_TRIALS_H_
#define ANDROID_WEBVIEW_BROWSER_AW_FIELD_TRIALS_H_

#include "base/macros.h"
#include "components/variations/platform_field_trials.h"

// Responsible for setting up field trials specific to WebView. Currently all
Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/aw_form_database_service.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
#define ANDROID_WEBVIEW_BROWSER_AW_FORM_DATABASE_SERVICE_H_

#include "base/files/file_path.h"
#include "base/macros.h"
#include "base/synchronization/waitable_event.h"
#include "components/autofill/core/browser/webdata/autofill_webdata_service.h"
#include "components/webdata/common/web_data_service_consumer.h"
Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/aw_javascript_dialog_manager.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
#ifndef ANDROID_WEBVIEW_BROWSER_AW_JAVASCRIPT_DIALOG_MANAGER_H_
#define ANDROID_WEBVIEW_BROWSER_AW_JAVASCRIPT_DIALOG_MANAGER_H_

#include "base/macros.h"
#include "content/public/browser/javascript_dialog_manager.h"

namespace android_webview {
Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/aw_pdf_exporter.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@

#include "base/android/jni_weak_ref.h"
#include "base/android/scoped_java_ref.h"
#include "base/macros.h"

#include "printing/page_range.h"

Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/aw_permission_manager.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

#include "base/callback_forward.h"
#include "base/containers/id_map.h"
#include "base/macros.h"
#include "base/memory/weak_ptr.h"
#include "content/public/browser/permission_controller_delegate.h"

Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/aw_print_manager.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@

#include <memory>

#include "base/macros.h"
#include "components/printing/browser/print_manager.h"
#include "components/printing/common/print.mojom-forward.h"
#include "content/public/browser/web_contents_user_data.h"
Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/aw_quota_manager_bridge.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@

#include "base/android/jni_weak_ref.h"
#include "base/callback.h"
#include "base/macros.h"
#include "base/memory/ref_counted.h"
#include "base/memory/weak_ptr.h"

Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/aw_quota_permission_context.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
#define ANDROID_WEBVIEW_BROWSER_AW_QUOTA_PERMISSION_CONTEXT_H_

#include "base/compiler_specific.h"
#include "base/macros.h"
#include "content/public/browser/quota_permission_context.h"

namespace android_webview {
Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/aw_resource_context.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
#include <map>
#include <string>

#include "base/macros.h"
#include "base/synchronization/lock.h"
#include "content/public/browser/resource_context.h"

Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/aw_settings.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
#include "android_webview/common/aw_content_client.h"
#include "base/android/jni_android.h"
#include "base/android/jni_string.h"
#include "base/macros.h"
#include "base/supports_user_data.h"
#include "components/viz/common/features.h"
#include "content/public/browser/navigation_controller.h"
Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/aw_speech_recognition_manager_delegate.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
#include <string>

#include "base/bind.h"
#include "base/macros.h"
#include "base/threading/thread_restrictions.h"
#include "build/build_config.h"
#include "components/prefs/pref_service.h"
Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/aw_speech_recognition_manager_delegate.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
#define ANDROID_WEBVIEW_BROWSER_AW_SPEECH_RECOGNITION_MANAGER_DELEGATE_H_

#include "base/compiler_specific.h"
#include "base/macros.h"
#include "content/public/browser/speech_recognition_event_listener.h"
#include "content/public/browser/speech_recognition_manager_delegate.h"
#include "content/public/browser/speech_recognition_session_config.h"
Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/aw_ssl_host_state_delegate.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
#include <map>
#include <string>

#include "base/macros.h"
#include "content/public/browser/ssl_host_state_delegate.h"
#include "net/base/hash_value.h"
#include "net/cert/x509_certificate.h"
Expand Down
2 changes: 0 additions & 2 deletions android_webview/browser/aw_web_contents_view_delegate.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@

#include "content/public/browser/web_contents_view_delegate.h"

#include "base/macros.h"

namespace content {
class WebContents;
} // namespace content
Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/aw_web_ui_controller_factory.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
#ifndef ANDROID_WEBVIEW_BROWSER_AW_WEB_UI_CONTROLLER_FACTORY_H_
#define ANDROID_WEBVIEW_BROWSER_AW_WEB_UI_CONTROLLER_FACTORY_H_

#include "base/macros.h"
#include "base/memory/singleton.h"
#include "content/public/browser/web_ui_controller_factory.h"

Expand Down
2 changes: 0 additions & 2 deletions android_webview/browser/find_helper.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@

#include <string>

#include "base/macros.h"

namespace content {
class WebContents;
} // namespace content
Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/gfx/aw_draw_fn_impl.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
#include "android_webview/browser/gfx/vulkan_gl_interop.h"
#include "android_webview/public/browser/draw_fn.h"
#include "base/android/scoped_java_ref.h"
#include "base/macros.h"
#include "third_party/abseil-cpp/absl/types/optional.h"
#include "third_party/skia/include/core/SkRefCnt.h"

Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/gfx/aw_gl_surface.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
#ifndef ANDROID_WEBVIEW_BROWSER_GFX_AW_GL_SURFACE_H_
#define ANDROID_WEBVIEW_BROWSER_GFX_AW_GL_SURFACE_H_

#include "base/macros.h"
#include "ui/gfx/geometry/rect.h"
#include "ui/gfx/geometry/transform.h"
#include "ui/gl/gl_surface_egl.h"
Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/gfx/aw_picture.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
#define ANDROID_WEBVIEW_BROWSER_GFX_AW_PICTURE_H_

#include "base/android/jni_weak_ref.h"
#include "base/macros.h"
#include "third_party/skia/include/core/SkRefCnt.h"

class SkPicture;
Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/gfx/aw_vulkan_context_provider.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@

#include <memory>

#include "base/macros.h"
#include "components/viz/common/gpu/vulkan_context_provider.h"
#include "gpu/vulkan/vulkan_device_queue.h"
#include "third_party/abseil-cpp/absl/types/optional.h"
Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/gfx/browser_view_renderer.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
#include "android_webview/browser/gfx/root_frame_sink_proxy.h"
#include "base/callback.h"
#include "base/cancelable_callback.h"
#include "base/macros.h"
#include "base/memory/ref_counted.h"
#include "base/trace_event/trace_event.h"
#include "components/viz/common/surfaces/frame_sink_id.h"
Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/gfx/child_frame.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
#include <vector>

#include "base/containers/circular_deque.h"
#include "base/macros.h"
#include "components/viz/common/surfaces/frame_sink_id.h"
#include "components/viz/common/surfaces/surface_id.h"
#include "content/public/browser/android/synchronous_compositor.h"
Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/gfx/deferred_gpu_command_service.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
#ifndef ANDROID_WEBVIEW_BROWSER_GFX_DEFERRED_GPU_COMMAND_SERVICE_H_
#define ANDROID_WEBVIEW_BROWSER_GFX_DEFERRED_GPU_COMMAND_SERVICE_H_

#include "base/macros.h"
#include "gpu/ipc/command_buffer_task_executor.h"

namespace gl {
Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/gfx/gpu_service_webview.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
#include <memory>
#include <utility>

#include "base/macros.h"
#include "gpu/config/gpu_feature_info.h"
#include "gpu/config/gpu_info.h"
#include "gpu/config/gpu_preferences.h"
Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/gfx/hardware_renderer.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

#include "android_webview/browser/gfx/child_frame.h"
#include "android_webview/browser/gfx/output_surface_provider_webview.h"
#include "base/macros.h"
#include "ui/gfx/android/android_surface_control_compat.h"
#include "ui/gfx/color_space.h"

Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/gfx/hardware_renderer_viz.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
#include "android_webview/common/aw_switches.h"
#include "base/command_line.h"
#include "base/logging.h"
#include "base/macros.h"
#include "base/notreached.h"
#include "base/trace_event/trace_event.h"
#include "components/viz/common/display/renderer_settings.h"
Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/gfx/hardware_renderer_viz.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
#include "android_webview/browser/gfx/hardware_renderer.h"
#include "android_webview/browser/gfx/output_surface_provider_webview.h"
#include "android_webview/browser/gfx/root_frame_sink.h"
#include "base/macros.h"
#include "base/threading/thread_checker.h"
#include "components/viz/common/surfaces/frame_sink_id.h"

Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/gfx/render_thread_manager.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
#include "android_webview/browser/gfx/parent_compositor_draw_constraints.h"
#include "android_webview/browser/gfx/root_frame_sink.h"
#include "base/check.h"
#include "base/macros.h"
#include "base/memory/weak_ptr.h"
#include "base/synchronization/lock.h"
#include "base/task/single_thread_task_runner.h"
Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/gfx/root_frame_sink.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
#include <memory>

#include "base/callback.h"
#include "base/macros.h"
#include "base/threading/thread_checker.h"
#include "components/viz/common/frame_sinks/begin_frame_source.h"
#include "components/viz/common/frame_timing_details_map.h"
Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/gfx/root_frame_sink_proxy.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
#define ANDROID_WEBVIEW_BROWSER_GFX_ROOT_FRAME_SINK_PROXY_H_

#include "android_webview/browser/gfx/root_frame_sink.h"
#include "base/macros.h"
#include "base/task/single_thread_task_runner.h"
#include "base/threading/thread_checker.h"

Expand Down
2 changes: 0 additions & 2 deletions android_webview/browser/gfx/scoped_app_gl_state_restore.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@
#include <memory>
#include <vector>

#include "base/macros.h"

namespace android_webview {

struct StencilState {
Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/gfx/scoped_app_gl_state_restore_impl.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
#include <vector>

#include "android_webview/browser/gfx/scoped_app_gl_state_restore.h"
#include "base/macros.h"
#include "ui/gl/gl_bindings.h"

namespace android_webview {
Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/gfx/scoped_app_gl_state_restore_impl_angle.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

#include "android_webview/browser/gfx/scoped_app_gl_state_restore.h"
#include "base/dcheck_is_on.h"
#include "base/macros.h"

namespace android_webview {
namespace internal {
Expand Down
1 change: 0 additions & 1 deletion android_webview/browser/gfx/task_queue_webview.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
#define ANDROID_WEBVIEW_BROWSER_GFX_TASK_QUEUE_WEBVIEW_H_

#include "base/callback.h"
#include "base/macros.h"
#include "base/memory/scoped_refptr.h"
#include "base/task/single_thread_task_runner.h"

Expand Down
Loading

0 comments on commit 5666ff4

Please sign in to comment.