Skip to content

Commit

Permalink
Add reserved optimization type
Browse files Browse the repository at this point in the history
This CL adds a reserved optimization type to align with server-side
setup

Bug: b/294438673
Change-Id: I9da3b668b6359052849640f9cc5d4684c6601e71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4756461
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1180423}
  • Loading branch information
Yue Zhang authored and Chromium LUCI CQ committed Aug 7, 2023
1 parent 552d366 commit 59ca1f1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions components/optimization_guide/proto/hints.proto
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ message GetHintsResponse {
// Must sync with enum OptimizationType in enums.xml for metric recording.
enum OptimizationType {
// Values for obsolete optimizations.
reserved 11, 12, 16, 29;
reserved 11, 12, 16, 29, 32;

TYPE_UNSPECIFIED = 0;
// This optimization blocks JavaScript on the page.
Expand Down Expand Up @@ -193,7 +193,7 @@ enum OptimizationType {
V8_COMPILE_HINTS = 31;
// This optimization provides information about shoppinge page types of this
// page.
SHOPPING_PAGE_TYPES = 32;
SHOPPING_PAGE_TYPES = 33;
}

// Presents semantics for how page load URLs should be matched.
Expand Down
2 changes: 1 addition & 1 deletion tools/metrics/histograms/enums.xml
Original file line number Diff line number Diff line change
Expand Up @@ -79550,7 +79550,7 @@ Called by update_net_trust_anchors.py.-->
<int value="29" label="Deprecated1"/>
<int value="30" label="PRICE_INSIGHTS"/>
<int value="31" label="V8_COMPILE_HINTS"/>
<int value="32" label="SHOPPING_PAGE_TYPES"/>
<int value="33" label="SHOPPING_PAGE_TYPES"/>
</enum>

<enum name="OptOutBlacklistReason">
Expand Down

0 comments on commit 59ca1f1

Please sign in to comment.