Fix ASAN component builds by adding proper dependencies to executable…

… targets. Before this CL, building |gn_all| ninja target fails with linking errors similar to: ../../buildtools/third_party/libc++/trunk/include/string:2027: error: undefined reference to 'std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >::__init(char const*, unsigned long)' After this CL |gn_all| builds find in with the following args.gn: dcheck_always_on = true is_asan = true is_component_build = true is_debug = false use_goma = true enable_nacl = false This CL is sort of a a follow up to https://groups.google.com/a/chromium.org/forum/#!searchin/gn-dev/asan/gn-dev/PTcQk8c9vXE/rfU-nAArBQAJ BUG= Review-Url: https://codereview.chromium.org/2808863003 Cr-Commit-Position: refs/heads/master@{#464747}
Denger-Network · Apr 14, 2017 · 5b312d9 · 5b312d9
1 parent 1cabd22
commit 5b312d9
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 0 deletions.
diff --git a/content/browser/bluetooth/tools/BUILD.gn b/content/browser/bluetooth/tools/BUILD.gn
@@ -9,6 +9,7 @@ executable("bluetooth_metrics_hash") {
 
   deps = [
     "//base",
+    "//build/config/sanitizers:deps",
     "//build/win:default_exe_manifest",
     "//device/bluetooth",
   ]

diff --git a/net/tools/transport_security_state_generator/BUILD.gn b/net/tools/transport_security_state_generator/BUILD.gn
@@ -62,6 +62,7 @@ executable("transport_security_state_generator") {
   deps = [
     ":transport_security_state_generator_sources",
     "//base",
+    "//build/config/sanitizers:deps",
     "//crypto",
     "//third_party/boringssl",
   ]

diff --git a/remoting/host/linux/BUILD.gn b/remoting/host/linux/BUILD.gn
@@ -16,6 +16,7 @@ if (enable_me2me_host) {
 
     deps = [
       "//base",
+      "//build/config/sanitizers:deps",
     ]
 
     libs = [ "pam" ]

diff --git a/services/service_manager/tests/connect/BUILD.gn b/services/service_manager/tests/connect/BUILD.gn
@@ -144,6 +144,7 @@ executable("connect_test_exe") {
   deps = [
     ":interfaces",
     "//base",
+    "//build/config/sanitizers:deps",
     "//build/win:default_exe_manifest",
     "//services/service_manager/public/cpp",
     "//services/service_manager/public/cpp/standalone_service:main",

diff --git a/services/service_manager/tests/lifecycle/BUILD.gn b/services/service_manager/tests/lifecycle/BUILD.gn
@@ -132,6 +132,7 @@ executable("lifecycle_unittest_exe") {
   deps = [
     ":app_client",
     "//base",
+    "//build/config/sanitizers:deps",
     "//build/win:default_exe_manifest",
     "//services/service_manager/public/cpp:sources",
     "//services/service_manager/public/cpp/standalone_service:main",

diff --git a/services/service_manager/tests/service_manager/BUILD.gn b/services/service_manager/tests/service_manager/BUILD.gn
@@ -57,6 +57,7 @@ executable("service_manager_unittest_target") {
   deps = [
     ":interfaces",
     "//base",
+    "//build/config/sanitizers:deps",
     "//build/win:default_exe_manifest",
     "//services/service_manager/public/cpp",
     "//services/service_manager/public/cpp/standalone_service:main",

diff --git a/tools/battor_agent/BUILD.gn b/tools/battor_agent/BUILD.gn
@@ -14,6 +14,7 @@ executable("battor_agent") {
   deps = [
     ":battor_agent_lib",
     "//base",
+    "//build/config/sanitizers:deps",
     "//build/win:default_exe_manifest",
     "//device/serial",
   ]